Updates named pipe to allow connection of non-elevated helper app to elevated plugin. (#28)

* Updates named pipe to allow connection of non-elevated helper app to elevated plugin.
* Updates version to 1.0.1

Author: FiniteSingularity

buildspec.json

@@ -40,7 +40,7 @@
     "displayName": "Elgato Marketplace Connect",
     "versionMajor": 1,
     "versionMinor": 0,
-    "versionPatch": 0,
+    "versionPatch": 1,
     "buildNumber": 0,
     "releaseType": "release",
     "author": "Elgato",

loader/main.cpp

@@ -91,6 +91,14 @@ int send_auth_to_obs(std::string payload) {
 	std::string base_name = "\\\\.\\pipe\\" + pipe_name;
 	std::string attempt_name;
 	HANDLE pipe = INVALID_HANDLE_VALUE;
+	SECURITY_ATTRIBUTES sa;
+	SECURITY_DESCRIPTOR sd;
+	InitializeSecurityDescriptor(&sd, SECURITY_DESCRIPTOR_REVISION);
+	SetSecurityDescriptorDacl(&sd, TRUE, NULL, FALSE);
+	sa.nLength = sizeof(sa);
+	sa.lpSecurityDescriptor = &sd;
+	sa.bInheritHandle = FALSE;
+
 	int connect_attempts_remaining = 6;
 
 	while (connect_attempts_remaining-- > 0 &&
@@ -100,7 +108,7 @@ int send_auth_to_obs(std::string payload) {
 			attempt_name = base_name + std::to_string(pipe_number);
 			printf("Attempting %s\n", attempt_name.c_str());
 			pipe = CreateFileA(attempt_name.c_str(), GENERIC_WRITE,
-				0, NULL, OPEN_EXISTING, 0, NULL);
+				0, &sa, OPEN_EXISTING, 0, NULL);
 			if (pipe != INVALID_HANDLE_VALUE) {
 				printf("Success\n");
 				break;

src/platform.cpp

@@ -182,13 +182,25 @@ bool listen_on_pipe(const std::string &pipe_name,
 		obs_log(LOG_INFO, "Creating pipe...");
 		HANDLE pipe = INVALID_HANDLE_VALUE;
 
+		SECURITY_ATTRIBUTES sa;
+		SECURITY_DESCRIPTOR sd;
+		InitializeSecurityDescriptor(&sd, SECURITY_DESCRIPTOR_REVISION);
+		SetSecurityDescriptorDacl(&sd, TRUE, NULL, FALSE);
+		sa.nLength = sizeof(sa);
+		sa.lpSecurityDescriptor = &sd;
+		sa.bInheritHandle = FALSE;
+
 		while (pipe_number < 10) {
 			attempt_name = base_name + std::to_string(pipe_number);
 			pipe = CreateNamedPipeA(
-				attempt_name.c_str(), PIPE_ACCESS_INBOUND,
-				PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE |
-					PIPE_WAIT | PIPE_REJECT_REMOTE_CLIENTS,
-				1, 1024, 1024, 0, NULL);
+				attempt_name.c_str(),
+				PIPE_ACCESS_DUPLEX,
+				PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE | PIPE_WAIT,
+				PIPE_UNLIMITED_INSTANCES,
+				512, 512,
+				0,
+				&sa
+			);
 			if (pipe != INVALID_HANDLE_VALUE) {
 				break;
 			}