Merge pull request #910 from eliashaeussler/feature/typed-extconf

Author: eliashaeussler

Classes/Backend/ContextMenu/ItemProviders/CacheWarmupProvider.php

@@ -87,7 +87,7 @@ public function __construct(
     protected function canRender(string $itemName, string $type): bool
     {
         // Early return if cache warmup from page tree is disabled globally
-        if (!$this->configuration->isEnabledInPageTree()) {
+        if (!$this->configuration->enabledInPageTree) {
             return false;
         }
 
@@ -98,7 +98,7 @@ protected function canRender(string $itemName, string $type): bool
 
         // Non-supported doktypes are never renderable
         $doktype = (int)($this->record['doktype'] ?? null);
-        if ($doktype <= 0 || !\in_array($doktype, $this->configuration->getSupportedDoktypes(), true)) {
+        if ($doktype <= 0 || !\in_array($doktype, $this->configuration->supportedDoktypes, true)) {
             return false;
         }
 

Classes/Backend/ToolbarItems/CacheWarmupToolbarItem.php

@@ -92,7 +92,7 @@ public function __construct(
     public function checkAccess(): bool
     {
         // Early return if cache warmup from backend toolbar is disabled globally
-        if (!$this->configuration->isEnabledInToolbar()) {
+        if (!$this->configuration->enabledInToolbar) {
             return false;
         }
 

Classes/Command/WarmupCommand.php

@@ -68,7 +68,7 @@ protected function configure(): void
             $this->crawlingStrategyFactory->getAll(),
         ));
 
-        $crawlingStrategy = $this->configuration->getStrategy();
+        $crawlingStrategy = $this->configuration->crawlingStrategy;
         if ($crawlingStrategy !== null) {
             $crawlingStrategy = $crawlingStrategy::getName();
         }
@@ -140,7 +140,7 @@ protected function configure(): void
   ├─ The maximum number of pages to be warmed up can be defined via the extension configuration <info>limit</info>.
   │  It can be overridden by using the <info>--limit</info> option.
   │  The value <info>0</info> deactivates the crawl limit.
-  ├─ Default: <info>{$v($this->configuration->getLimit())}</info>
+  ├─ Default: <info>{$v($this->configuration->limit)}</info>
   ├─ Example: <comment>warming:cachewarmup -s 1 --limit 100</comment> (limits crawling to 100 pages)
   └─ Example: <comment>warming:cachewarmup -s 1 --limit 0</comment> (no limit)
 
@@ -166,8 +166,8 @@ protected function configure(): void
   ├─ Use the extension configuration <info>verboseCrawler</info> to use an alternative crawler for
   │  command-line requests. For warmup requests triggered via the TYPO3 backend, you can use the
   │  extension configuration <info>crawler</info>.
-  ├─ Currently used default crawler: <info>{$v($this->configuration->getCrawler()::class)}</info>
-  └─ Currently used verbose crawler: <info>{$v($this->configuration->getVerboseCrawler()::class)}</info>
+  ├─ Currently used default crawler: <info>{$v($this->configuration->crawlerClass)}</info>
+  └─ Currently used verbose crawler: <info>{$v($this->configuration->verboseCrawlerClass)}</info>
 
 * <comment>Custom User-Agent header</comment>
   ├─ When the default crawler is used, each warmup request is executed with a special User-Agent header.
@@ -206,7 +206,7 @@ protected function configure(): void
             null,
             Console\Input\InputOption::VALUE_REQUIRED,
             'Maximum number of pages to be crawled. Set to <info>0</info> to disable the limit.',
-            $this->configuration->getLimit(),
+            $this->configuration->limit,
         );
         $this->addOption(
             'strategy',
@@ -289,17 +289,16 @@ private function prepareCommandParameters(Console\Input\InputInterface $input):
         $format = $input->getOption('format');
 
         // Fetch input options from extension configuration
-        $excludePatterns = $this->configuration->getExcludePatterns();
-        $crawler = $this->configuration->getVerboseCrawler();
-        $crawlerOptions = $this->configuration->getVerboseCrawlerOptions();
-        $parserOptions = $this->configuration->getParserOptions();
+        $excludePatterns = $this->configuration->excludePatterns;
+        $crawlerOptions = $this->configuration->verboseCrawlerOptions;
+        $parserOptions = $this->configuration->parserOptions;
 
         // Initialize sub-command parameters
         $subCommandParameters = [
             'sitemaps' => $sitemaps,
             '--urls' => $urls,
             '--limit' => $limit,
-            '--crawler' => $crawler::class,
+            '--crawler' => $this->configuration->verboseCrawlerClass,
             '--format' => $format,
         ];