Skip to content

Commit 06d7ca0

Browse files
chore: clear version for app publication (#441)
1 parent 4b4152d commit 06d7ca0

File tree

3 files changed

+6
-17
lines changed

3 files changed

+6
-17
lines changed

apps/ai-dial-admin/src/components/EntityMainProperties/BaseProperties/DisplayName.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,12 @@ import { getErrorForDisplayName } from '@/src/utils/validation/name-error';
1010
interface Props {
1111
displayName?: string;
1212
required?: boolean;
13+
readonly?: boolean;
14+
disabled?: boolean;
1315
onChange?: (displayName: string) => void;
1416
}
1517

16-
const DisplayNameControl: FC<Props> = ({ displayName, onChange, required }) => {
18+
const DisplayNameControl: FC<Props> = ({ displayName, onChange, required, ...props }) => {
1719
const t = useI18n() as (t: string) => string;
1820
const { dispatch } = useSaveValidationContext();
1921

@@ -46,6 +48,7 @@ const DisplayNameControl: FC<Props> = ({ displayName, onChange, required }) => {
4648
onChange={onChangeDisplayName}
4749
errorText={displayNameError?.text}
4850
invalid={!!displayNameError}
51+
{...props}
4952
/>
5053
);
5154
};

apps/ai-dial-admin/src/components/PublicationView/ApplicationProperties/ApplicationInfo.tsx

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { FC } from 'react';
22

3-
import { TextInputField } from '@/src/components/Common/InputField/InputField';
43
import { EntityFieldsI18nKey } from '@/src/constants/i18n';
54
import { useI18n } from '@/src/locales/client';
65
import EntityIcon from '@/src/components/EntityView/Properties/EntityIcon';
76
import Multiselect from '@/src/components/Common/Multiselect/Multiselect';
87
import { DialApplicationResource } from '@/src/models/dial/application-resource';
98
import DescriptionControl from '@/src/components/EntityMainProperties/BaseProperties/Description';
9+
import DisplayNameControl from '@/src/components/EntityMainProperties/BaseProperties/DisplayName';
1010

1111
interface Props {
1212
application: DialApplicationResource;
@@ -17,19 +17,7 @@ const ApplicationInfo: FC<Props> = ({ application }) => {
1717

1818
return application ? (
1919
<div className="flex flex-col gap-y-6">
20-
<TextInputField
21-
elementId="displayName"
22-
readonly={true}
23-
fieldTitle={t(EntityFieldsI18nKey.displayName)}
24-
value={application?.displayName}
25-
/>
26-
<TextInputField
27-
readonly={true}
28-
elementId="displayVersion"
29-
fieldTitle={t(EntityFieldsI18nKey.displayVersion)}
30-
value={application?.displayVersion}
31-
/>
32-
20+
<DisplayNameControl readonly={true} displayName={application?.displayName} />
3321
<DescriptionControl entity={application} readonly={true} />
3422

3523
<EntityIcon

apps/ai-dial-admin/src/components/PublicationView/ApplicationProperties/tests/ApplicationInfo.spec.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ describe('ApplicationInfo', () => {
1717

1818
expect(screen.getByText(EntityFieldsI18nKey.displayName)).toBeInTheDocument();
1919
expect(screen.getByText('Test App')).toBeInTheDocument();
20-
expect(screen.getByText(EntityFieldsI18nKey.displayVersion)).toBeInTheDocument();
21-
expect(screen.getByText('1.0.0')).toBeInTheDocument();
2220
expect(screen.getByText(EntityFieldsI18nKey.description)).toBeInTheDocument();
2321
expect(screen.getByText('A test application')).toBeInTheDocument();
2422
expect(screen.getByText(EntityFieldsI18nKey.iconUrl)).toBeInTheDocument();

0 commit comments

Comments
 (0)