Skip to content

Commit f4bbe6a

Browse files
author
Dhruv Garg
committed
[simulator] check task state before invoking unschedule on it
1 parent 2a74838 commit f4bbe6a

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

simulator.py

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1445,17 +1445,22 @@ def subtree_tasks_to_unschedule(task):
14451445
self._logger.warning(msg)
14461446

14471447
# Unschedule the task
1448-
unschedule_task.unschedule(event.time)
1449-
self._csv_logger.debug(
1450-
f"{event.time.time},TASK_UNSCHEDULED,{unschedule_task.name},{unschedule_task.timestamp},"
1451-
f"{unschedule_task.id},{unschedule_task.task_graph}"
1452-
)
1453-
1454-
self._logger.info(
1455-
"[%s] Finished unscheduling of task %s.",
1456-
event.time.time,
1457-
unschedule_task,
1458-
)
1448+
if unschedule_task.state == TaskState.SCHEDULED:
1449+
unschedule_task.unschedule(event.time)
1450+
self._csv_logger.debug(
1451+
f"{event.time.time},TASK_UNSCHEDULED,{unschedule_task.name},{unschedule_task.timestamp},"
1452+
f"{unschedule_task.id},{unschedule_task.task_graph}"
1453+
)
1454+
msg = (
1455+
f"[{event.time.time}] Finished unscheduling of task {unschedule_task}."
1456+
)
1457+
self._logger.info(msg)
1458+
else:
1459+
msg = (
1460+
f"[{event.time.time}] Task {unschedule_task} was not in SCHEDULED state and was in "
1461+
f"{unschedule_task.state} state. Skip unscheduling."
1462+
)
1463+
self._logger.info(msg)
14591464

14601465
if not task.is_ready_to_run(task_graph):
14611466
if task.state == TaskState.CANCELLED or task_graph.is_cancelled():

0 commit comments

Comments
 (0)