Remove side effects from conditional in purr.

ericonr · ericonr · commit ae4641fcd455 · 2025-01-13T16:11:06.000-03:00
Based on SonarQube rule: c:S912.
diff --git a/purr.c b/purr.c
@@ -221,9 +221,10 @@ int main (int argc, char **argv)
     }
 
     // clean up hash property, if present
-    char *hash_prop;
-    if (!encrypt && (hash_prop = strchr(path, '#'))) {
-        *hash_prop = 0;
+    if (!encrypt) {
+        char *hash_prop = strchr(path, '#');
+        if (hash_prop)
+            *hash_prop = 0;
     }
 
     uint8_t *key = NULL;

Original file line number	Diff line number	Diff line change
`@@ -221,9 +221,10 @@ int main (int argc, char **argv)`
`221`	`221`	`}`
`222`	`222`
`223`	`223`	`// clean up hash property, if present`
`224`		`- char *hash_prop;`
`225`		`- if (!encrypt && (hash_prop = strchr(path, '#'))) {`
`226`		`- *hash_prop = 0;`
	`224`	`+ if (!encrypt) {`
	`225`	`+ char *hash_prop = strchr(path, '#');`
	`226`	`+ if (hash_prop)`
	`227`	`+ *hash_prop = 0;`
`227`	`228`	`}`
`228`	`229`
`229`	`230`	`uint8_t *key = NULL;`