Skip to content

Commit 32151fb

Browse files
Fixing GraphQL SSE crash with large stanza payloads
1 parent 344108f commit 32151fb

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

big_tests/tests/graphql_sse_SUITE.erl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,10 @@ sse_should_not_get_timeout(Config) ->
145145
timer:sleep(2000),
146146
escalus:send(Bob, escalus_stanza:chat(From, To, <<"Hello again!">>)),
147147
sse_helper:wait_for_event(Stream),
148+
timer:sleep(2000),
149+
Message = binary:copy(<<"0">>, 2000),
150+
escalus:send(Bob, escalus_stanza:chat(From, To, Message)),
151+
sse_helper:wait_for_event(Stream),
148152
sse_helper:stop_sse(Stream)
149153
end).
150154

src/graphql/mongoose_graphql_response.erl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
-export([term_to_json/1, term_to_pretty_json/1]).
44

55
term_to_json(Term) ->
6-
jiffy:encode(fixup(Term)).
6+
iolist_to_binary(jiffy:encode(fixup(Term))).
77

88
term_to_pretty_json(Term) ->
9-
jiffy:encode(fixup(Term), [pretty]).
9+
iolist_to_binary(jiffy:encode(fixup(Term), [pretty])).
1010

1111
%% Ground types
1212
fixup(Term) when is_number(Term) -> Term;

0 commit comments

Comments
 (0)