Simplify inbox_helper:maybe_run_in_parallel/1

Author: arcusfelis

big_tests/tests/ct_helper.erl

@@ -6,7 +6,8 @@
          repeat_all_until_any_fail/2,
          groups_to_all/1,
          get_preset_var/3,
-         get_internal_database/0]).
+         get_internal_database/0,
+         add_params_to_list/3]).
 
 -type group_name() :: atom().
 
@@ -131,3 +132,16 @@ get_internal_database() ->
         {ok, _} -> cets;
         {error, not_found} -> mnesia
     end.
+
+add_params_to_list(Groups, [], _IgnoreNames) ->
+    Groups;
+add_params_to_list(Groups, NewParams, IgnoreNames) ->
+    [add_params(Group, NewParams, IgnoreNames) || Group <- Groups].
+
+add_params({Name, Params, Tests} = Group, NewParams, IgnoreNames) ->
+    case lists:member(Name, IgnoreNames) of
+        true ->
+            Group;
+        false ->
+            {Name, NewParams ++ Params, Tests}
+    end.

big_tests/tests/inbox_helper.erl

@@ -144,26 +144,11 @@ skip_or_run_inbox_tests(TestCases) ->
     end.
 
 maybe_run_in_parallel(Gs) ->
-    %% These could be parallel but it seems like mssql CI can't handle the load
-    case distributed_helper:rpc(
-           distributed_helper:mim(), mongoose_rdbms, db_engine, [domain_helper:host_type()]) of
-        odbc -> Gs;
-        _ -> insert_parallels(Gs)
-    end.
+    NewParams = distributed_helper:maybe_parallel_group(),
+    ct_helper:add_params_to_list(Gs, NewParams, non_parallel_groups()).
 
-insert_parallels(Gs) ->
-    Fun = fun({muclight_config, Conf, Tests}) ->
-                  {muclight_config, Conf, Tests};
-             ({bin, Conf, Tests}) ->
-                  {bin, Conf, Tests};
-             ({regular, Conf, Tests}) ->
-                  {regular, Conf, Tests};
-             ({async_pools, Conf, Tests}) ->
-                  {async_pools, Conf, Tests};
-             ({Group, Conf, Tests}) ->
-                  {Group, [parallel | Conf], Tests}
-          end,
-    lists:map(Fun, Gs).
+non_parallel_groups() ->
+    [muclight_config, bin, regular, async_pools].
 
 inbox_modules(Backend) ->
     [