Invalid CRD with when no string default value is used

[mfvitale]

Describe the bug

With the generator v2 the default are not working as expected. If you define for example

@Default(defaultValue = "60000")
private long flushMs = 60000L;

the generated crd will put the default value as a string causing the crd to not be valid.

Error from server (Invalid): error when creating "k8/debeziumservers.debezium.io-v1.yml": CustomResourceDefinition.apiextensions.k8s.io "debeziumservers.debezium.io" is invalid: [spec.validation.openAPIV3Schema.properties[spec].properties[source].properties[offset].properties[flushMs].default: Invalid value: "string":  in body must be of type integer: 

Fabric8 Kubernetes Client version

6.13.4

Steps to reproduce

Maybe adding a test in

kubernetes-client/crd-generator/api-v2/src/test/java/io/fabric8/crdv2/generator/v1/JsonSchemaTest.java

Line 70 in ef59440

class JsonSchemaTest {

will be a good starting point to easily reproduce it.

Expected behavior

The correct default value should be used.

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.25.3@latest

Environment

Linux

Fabric8 Kubernetes Client Logs

No response

Additional context

No response

[mfvitale]

@andreaTP

[manusa]

Additional context:

The issue is applicable for both the @Default annotation and the @JsonProperty defaultValue:

kubernetes-client/crd-generator/api-v2/src/main/java/io/fabric8/crdv2/generator/AbstractJsonSchema.java

Line 244 in 4beec62

defaultValue = beanProperty.getMetadata().getDefaultValue();

kubernetes-client/crd-generator/api-v2/src/main/java/io/fabric8/crdv2/generator/AbstractJsonSchema.java

Line 274 in 4beec62

defaultValue = ofNullable(beanProperty.getAnnotation(Default.class)).map(Default::value).orElse(defaultValue);

For CRD v1 this is only applicable to the @Default annotation, the @JsonProperty defaultValue config is not taken into account:

kubernetes-client/crd-generator/api/src/main/java/io/fabric8/crd/generator/AbstractJsonSchema.java

Lines 451 to 453 in 1e952e0

	case ANNOTATION_DEFAULT:
	defaultValue = (String) a.getParameters().get(VALUE);
	break;

The issue is now visible because the Quarkus Operator SDK switched to use CRD v2 in quarkiverse/quarkus-operator-sdk#927

🙌🙌🙌 @metacosm has added a fix in Quarkus Operator SDK to be able to use CRD v1: quarkiverse/quarkus-operator-sdk#1007

quarkiverse/quarkus-operator-sdk#1009

A release with the fix will be available in: https://github.com/quarkiverse/quarkus-operator-sdk/releases/tag/6.9.1

[metacosm]

I have also backported the change to 6.8.5, which should also be released today.

[e-roeling]

Would it be possible to backport this change to 6.13.x? We are currently on 6.13.4 and we can't update to 7.0.x directly.

[manusa]

Would it be possible to backport this change to 6.13.x? We are currently on 6.13.4 and we can't update to 7.0.x directly.

HI @e-roeling, we can try to backport the changes if the branches didn't diverge too much.

[manusa]

Hi @e-roeling,
This PR requires backporting additional commits that affect the CRD-Generator v2 and that improve its functionality while breaking its 6.13 standard behavior.

It will probably be much less effort for you to upgrade to Kubernetes Client 7.
Unless you're bound to Java 8, there aren't really that many breaking changes in this release.