Replies: 1 comment 1 reply
-
@SIR-unit if you make backwards compatible changes, it would be ok by me 👍 |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I noticed there are some differences with upstream. Specifically, this code has parse_opt() moved into main() for detect.py and val.py. I would like to be able to do something like so in my code:
Simply calling run() does not work because, in train.py, it calls parse_opt(True), which causes misspelled arguments to silently fail, and in detect.py and val.py, run() doesn't call parse_opt() at all. More importantly, main() has other code which is useful when running from cli, so I really want to be able to call main() with other options; this is especially true for val.py, whose main() does things other than check dependencies and call run()
I understand that you might not want to break codes that rely on this difference, but If I make a pull request with a backwards-compatible change which addresses this, would it be accepted? Specifically, I would change the first part of main() in detect.py and val.py to
Beta Was this translation helpful? Give feedback.
All reactions