Skip to content

Commit 3597053

Browse files
Merge pull request #232 from fingerprintjs/feature/INTER-744-node-20
feat: use node 20 in deployment template
2 parents bf49372 + fa9d8af commit 3597053

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

.github/workflows/analyze-commits.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ jobs:
1010
name: Generate docs and coverage report
1111
uses: fingerprintjs/dx-team-toolkit/.github/workflows/analyze-commits.yml@v1
1212
with:
13-
nodeVersion: 18
13+
nodeVersion: 20

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ jobs:
1414
name: Build project and run CI checks
1515
uses: fingerprintjs/dx-team-toolkit/.github/workflows/build-typescript-project.yml@v1
1616
with:
17-
nodeVersion: 18
17+
nodeVersion: 20

.github/workflows/coverage-diff.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ jobs:
1111
pull-requests: write
1212
uses: fingerprintjs/dx-team-toolkit/.github/workflows/coverage-diff.yml@v1
1313
with:
14-
nodeVersion: 16
14+
nodeVersion: 20

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
name: 'Build project, run CI checks and publish new release'
1212
uses: fingerprintjs/dx-team-toolkit/.github/workflows/release-typescript-project.yml@v1
1313
with:
14-
nodeVersion: 18
14+
nodeVersion: 20
1515
appId: ${{ vars.APP_ID }}
1616
secrets:
1717
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}

.node-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
18
1+
20

azuredeploy.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@
149149
{
150150
"type": "Microsoft.Authorization/roleAssignments",
151151
"apiVersion": "2022-04-01",
152-
"name": "[variables('roleAssignmentName')]",
152+
"name": "[variables('roleAssignmentName')]",
153153
"properties": {
154154
"roleDefinitionId": "[resourceId('Microsoft.Authorization/roleDefinitions', variables('roleDefinitionName'))]",
155155
"principalId": "[reference(resourceId('Microsoft.ManagedIdentity/userAssignedIdentities', variables('userAssignedIdentityName')), '2023-01-31').principalId]",
@@ -173,7 +173,7 @@
173173
"properties": {
174174
"accessTier": "Hot"
175175
}
176-
},
176+
},
177177
{
178178
"type": "Microsoft.Storage/storageAccounts/blobServices/containers",
179179
"apiVersion": "2022-05-01",
@@ -263,7 +263,7 @@
263263
"serverFarmId": "[resourceId('Microsoft.Web/serverfarms', variables('hostingPlanName'))]",
264264
"reserved": true,
265265
"siteConfig": {
266-
"linuxFxVersion": "Node|18",
266+
"linuxFxVersion": "Node|20",
267267
"minimumElasticInstanceCount": 1,
268268
"numberOfWorkers": 2,
269269
"appSettings": [
@@ -290,14 +290,14 @@
290290
{
291291
"name": "WEBSITE_CONTENTSHARE",
292292
"value": "[toLower(variables('functionAppName'))]"
293-
},
293+
},
294294
{
295295
"name": "USER_ASSIGNED_ENTITY_CLIENT_ID",
296296
"value": "[reference(resourceId('Microsoft.ManagedIdentity/userAssignedIdentities', variables('userAssignedIdentityName')), '2023-01-31').clientId]"
297297
},
298298
{
299299
"name": "WEBSITE_RUN_FROM_PACKAGE_BLOB_MI_RESOURCE_ID",
300-
"value": "[format('{0}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{1}', resourceGroup().id, variables('userAssignedIdentityName'))]"
300+
"value": "[format('{0}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{1}', resourceGroup().id, variables('userAssignedIdentityName'))]"
301301
},
302302
{
303303
"name": "WEBSITE_RUN_FROM_PACKAGE",

0 commit comments

Comments
 (0)