Skip to content

Commit b4cc8d4

Browse files
Merge pull request #196 from fingerprintjs/feature/INTER-1181-remove-manual-approval
Use runner app for schema sync
2 parents d9198dc + 177b68b commit b4cc8d4

File tree

2 files changed

+30
-23
lines changed

2 files changed

+30
-23
lines changed

.github/workflows/sync-server-side-sdks-schema.yml

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -45,84 +45,84 @@ jobs:
4545
sync-node:
4646
if: inputs.sync-node
4747
name: 'Sync schema in Node SDK'
48-
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@v1
48+
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@feat/INTER-1181-remove-manual-approval
4949
with:
5050
tag: ${{ inputs.tag }}
5151
language: node
5252
language-version: 21
5353
generate-command: 'pnpm generateTypes'
5454
schema-path: resources/fingerprint-server-api.yaml
5555
examples-path: tests/mocked-responses-tests/mocked-responses-data
56-
app-id: ${{ vars.APP_ID }}
56+
app-id: ${{ vars.RUNNER_APP_ID }}
5757
repository: fingerprintjs-pro-server-api-node-sdk
5858
pre-release: ${{ inputs.pre-release }}
5959
allowed-scopes: events,visitors,webhook,related-visitors,events-search
6060
force: ${{ inputs.force }}
6161
secrets:
62-
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
62+
APP_PRIVATE_KEY: ${{ secrets.RUNNER_APP_PRIVATE_KEY }}
6363

6464
sync-go:
6565
if: inputs.sync-go
6666
name: 'Sync schema in GO SDK'
67-
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@v1
67+
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@feat/INTER-1181-remove-manual-approval
6868
with:
6969
tag: ${{ inputs.tag }}
7070
language: golang
7171
language-version: 1.21
7272
generate-command: 'go run generate.go'
7373
schema-path: res/fingerprint-server-api.yaml
7474
examples-path: test/mocks
75-
app-id: ${{ vars.APP_ID }}
75+
app-id: ${{ vars.RUNNER_APP_ID }}
7676
repository: fingerprint-pro-server-api-go-sdk
7777
pre-release: ${{ inputs.pre-release }}
7878
allowed-scopes: events,visitors,webhook,related-visitors,events-search
7979
force: ${{ inputs.force }}
8080
secrets:
81-
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
81+
APP_PRIVATE_KEY: ${{ secrets.RUNNER_APP_PRIVATE_KEY }}
8282

8383
sync-dotnet:
8484
if: inputs.sync-dotnet
8585
name: 'Sync schema in Dotnet SDK'
86-
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@v1
86+
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@feat/INTER-1181-remove-manual-approval
8787
with:
8888
tag: ${{ inputs.tag }}
8989
language: dotnet
9090
language-version: '8.x'
9191
generate-command: 'bash ./generate.sh'
9292
schema-path: res/fingerprint-server-api.yaml
9393
examples-path: src/FingerprintPro.ServerSdk.Test/mocks
94-
app-id: ${{ vars.APP_ID }}
94+
app-id: ${{ vars.RUNNER_APP_ID }}
9595
repository: fingerprint-pro-server-api-dotnet-sdk
9696
pre-release: ${{ inputs.pre-release }}
9797
allowed-scopes: events,visitors,webhook,related-visitors,events-search
9898
force: ${{ inputs.force }}
9999
secrets:
100-
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
100+
APP_PRIVATE_KEY: ${{ secrets.RUNNER_APP_PRIVATE_KEY }}
101101

102102
sync-python:
103103
if: inputs.sync-python
104104
name: 'Sync schema in Python SDK'
105-
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@v1
105+
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@feat/INTER-1181-remove-manual-approval
106106
with:
107107
tag: ${{ inputs.tag }}
108108
language: python
109109
language-version: '3.12'
110110
generate-command: 'bash ./generate.sh'
111111
schema-path: res/fingerprint-server-api.yaml
112112
examples-path: test/mocks
113-
app-id: ${{ vars.APP_ID }}
113+
app-id: ${{ vars.RUNNER_APP_ID }}
114114
repository: fingerprint-pro-server-api-python-sdk
115115
pre-release: ${{ inputs.pre-release }}
116116
pre-release-tag: rc
117117
allowed-scopes: events,visitors,webhook,related-visitors,events-search
118118
force: ${{ inputs.force }}
119119
secrets:
120-
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
120+
APP_PRIVATE_KEY: ${{ secrets.RUNNER_APP_PRIVATE_KEY }}
121121

122122
sync-java:
123123
if: inputs.sync-java
124124
name: 'Sync schema in Java SDK'
125-
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@v1
125+
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@feat/INTER-1181-remove-manual-approval
126126
with:
127127
tag: ${{ inputs.tag }}
128128
language: java
@@ -131,31 +131,31 @@ jobs:
131131
generate-command: 'bash ./scripts/generate.sh'
132132
schema-path: res/fingerprint-server-api.yaml
133133
examples-path: sdk/src/test/resources/mocks
134-
app-id: ${{ vars.APP_ID }}
134+
app-id: ${{ vars.RUNNER_APP_ID }}
135135
repository: fingerprint-pro-server-api-java-sdk
136136
pre-release: ${{ inputs.pre-release }}
137137
pre-release-tag: develop
138138
allowed-scopes: events,visitors,webhook,related-visitors,events-search
139139
force: ${{ inputs.force }}
140140
secrets:
141-
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
141+
APP_PRIVATE_KEY: ${{ secrets.RUNNER_APP_PRIVATE_KEY }}
142142

143143
sync-php:
144144
if: inputs.sync-php
145145
name: 'Sync schema in PHP SDK'
146-
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@v1
146+
uses: fingerprintjs/dx-team-toolkit/.github/workflows/update-server-side-sdk-schema.yml@feat/INTER-1181-remove-manual-approval
147147
with:
148148
tag: ${{ inputs.tag }}
149149
language: php
150150
language-version: '8.3'
151151
generate-command: 'bash ./scripts/generate.sh'
152152
schema-path: res/fingerprint-server-api.yaml
153153
examples-path: test/mocks
154-
app-id: ${{ vars.APP_ID }}
154+
app-id: ${{ vars.RUNNER_APP_ID }}
155155
repository: fingerprint-pro-server-api-php-sdk
156156
pre-release: ${{ inputs.pre-release }}
157157
pre-release-tag: develop
158158
allowed-scopes: events,visitors,webhook,related-visitors,events-search
159159
force: ${{ inputs.force }}
160160
secrets:
161-
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
161+
APP_PRIVATE_KEY: ${{ secrets.RUNNER_APP_PRIVATE_KEY }}

.github/workflows/upload-changesets.yml

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,14 @@ jobs:
3030
cleanup-changesets:
3131
runs-on: ubuntu-latest
3232
needs: upload-changesets
33-
environment: production
3433
steps:
3534
- name: 'Get token for the GitHub App'
36-
if: ${{ vars.APP_ID != '' }}
35+
if: ${{ vars.RUNNER_APP_ID != '' }}
3736
uses: actions/create-github-app-token@f2acddfb5195534d487896a656232b016a682f3c
3837
id: app-token
3938
with:
40-
app-id: ${{ vars.APP_ID }}
41-
private-key: ${{ secrets.APP_PRIVATE_KEY }}
39+
app-id: ${{ vars.RUNNER_APP_ID }}
40+
private-key: ${{ secrets.RUNNER_APP_PRIVATE_KEY }}
4241

4342
- uses: actions/checkout@v4
4443
with:
@@ -53,4 +52,12 @@ jobs:
5352
with:
5453
add: '.'
5554
github_token: ${{ steps.app-token.outputs.token || secrets.GITHUB_TOKEN }}
56-
message: 'chore(skip-ci): remove changesets zip files'
55+
message: 'chore: remove changesets zip files'
56+
push: 'false'
57+
58+
- name: Create Pull Request
59+
uses: peter-evans/create-pull-request@c5a7806660adbe173f04e3e038b0ccdcd758773c
60+
with:
61+
title: 'Remove changesets zip after release ${{ github.event.release.tag_name }}'
62+
token: ${{ steps.app-token.outputs.token || secrets.GITHUB_TOKEN }}
63+
branch: chore/remove-changesets-zip-${{ github.event.release.tag_name }}

0 commit comments

Comments
 (0)