fix: Do not fallback for local accessors

Author: firedev

README.md

@@ -10,7 +10,7 @@ This gem uses PostgreSQL's JSONB datatype and ActiveRecord models to translate m
 
 ## Features
 
-- [x] `v0.1.2` It works
+- [x] `v0.1.3` Fix redundant fallbacks when translation is nil
 
 ## Requirements
 
@@ -71,10 +71,12 @@ It always falls back to default locale
 # Behavior with fallbacks enabled
 p = Page.new(title_en: 'English title')
 I18n.with_locale(:de) { p.title } # => 'English title' (falls back to English)
+p.title_de # => nil
 
 # Behavior with empty string
 p = Page.new(title_en: 'English title', title_de: '')
 I18n.with_locale(:de) { p.title } # => 'English title' (falls back since German is empty)
+p.title_de # => ''
 ```
 
 ### Assigning a Hash Directly

lib/awesome_jsonb_translate/active_record.rb

@@ -33,7 +33,7 @@ def define_translation_accessors(attr_name)
 
     def define_translation_reader_for_locale(attr_name, locale)
       define_method("#{attr_name}_#{locale}") do
-        read_translation(attr_name, locale)
+        read_translation_without_fallback(attr_name, locale)
       end
     end
 

lib/awesome_jsonb_translate/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AwesomeJsonbTranslate
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

spec/awesome_jsonb_translate_spec.rb

@@ -80,6 +80,15 @@ class Page < ActiveRecord::Base
         expect(page.title).to eq('English title')
       end
     end
+
+    it 'does not fall back when translation is accessed directly' do
+      page = Page.new(title_en: 'English title', title_de: nil)
+
+      I18n.with_locale(:de) do
+        expect(page.title_en).to eq('English title')
+        expect(page.title_de).to be_nil
+      end
+    end
   end
 
   describe 'querying' do