Skip to content

tabFilter no longer filters tabs #385

@DiamondIceNS

Description

@DiamondIceNS

Setting the tabFilter property in the config or relying on the automatically generated tabFilter per the documentation does not actually result in any filtered tabs. All tabs are attached regardless of filters. This gums up my console log with all console messages from all tabs I have open, rather than just the ones relevant to the app I'm trying to debug, which is quite annoying.

This seems to be a regression introduced in a29df5f. The tabFilter config option is only verified against processes, not tabs:

const url = targetActor.target.url;
if (
	descriptorActor.type === 'process' && !targetActor.target.addonId && url &&
	(!this.config.tabFilter.include.some(tabFilter => tabFilter.test(url)) ||
	this.config.tabFilter.exclude.some(tabFilter => tabFilter.test(url)))
) {
	skip = true;
}

This is allowing all tabs through regardless of URL.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions