Skip to content

Commit 5ccb6f6

Browse files
MagicBot/documentation-updates
1 parent 05ae576 commit 5ccb6f6

File tree

7 files changed

+77
-47
lines changed

7 files changed

+77
-47
lines changed

.github/ISSUE_TEMPLATE/bug-report.yml

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: 🐞 Bug
22
description: Report a bug or an issue you've found within the dbt package
33
title: "[Bug] <title>"
4-
labels: ["bug", "triage"]
4+
labels: ["type:bug"]
55
body:
66
- type: markdown
77
attributes:
@@ -35,6 +35,12 @@ body:
3535
description: A concise description of what you expected to happen.
3636
validations:
3737
required: true
38+
- type: textarea
39+
attributes:
40+
label: Possible solution
41+
description: Were you able to investigate and/or discover a potential fix to this bug in your investigation? If so, it would be much appreciated if you could submit code samples to show us how your fix resolved this issue.
42+
validations:
43+
required: false
3844
- type: textarea
3945
attributes:
4046
label: dbt Project configurations
@@ -61,6 +67,19 @@ body:
6167
- other (mention it in "Additional Context")
6268
validations:
6369
required: true
70+
- type: dropdown
71+
id: orchestration_type
72+
attributes:
73+
label: How are you running this dbt package?
74+
multiple: true
75+
options:
76+
- Fivetran Quickstart Data Model
77+
- Fivetran Transformations
78+
- dbt Core™
79+
- dbt Cloud™
80+
- other (mention it in "Additional Context")
81+
validations:
82+
required: true
6483
- type: textarea
6584
attributes:
6685
label: dbt Version
@@ -83,6 +102,6 @@ body:
83102
description: Our team will assess this issue and let you know if we will add it to a future sprint. However, if you would like to expedite the solution, we encourage you to contribute to the package via a PR. Our team will then work with you to approve and merge your contributions as soon as possible.
84103
options:
85104
- label: Yes.
86-
- label: Yes, but I will need assistance and will schedule time during our [office hours](https://calendly.com/fivetran-solutions-team/fivetran-solutions-team-office-hours) for guidance
105+
- label: Yes, but I will need assistance.
87106
- label: No.
88107
required: false

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
contact_links:
2-
- name: Ask a question during our office hours
3-
url: https://calendly.com/fivetran-solutions-team/fivetran-solutions-team-office-hours
4-
about: Schedule time during the external office hours block with the Fivetran Analytics Engineering team for support
2+
- name: Provide feedback to our dbt package team
3+
url: https://www.surveymonkey.com/r/DQ7K7WW
4+
about: Fill out our survey form to provide valuable feedback to the Fivetran team developing and maintaining the dbt packages.
55
- name: Fivetran connector question
66
url: https://support.fivetran.com/hc
77
about: Have a question about your connector? Check out the Fivetran support portal for more details.
@@ -10,4 +10,4 @@ contact_links:
1010
about: Check out the dbt docs for all dbt related information
1111
- name: Hang out in dbt Slack
1212
url: https://www.getdbt.com/community/
13-
about: Have a question or just want to chat with fellow data friends, join dbt Slack and hangout in the tools-fivetran channel with us!
13+
about: Have a question or just want to chat with fellow data friends, join dbt Slack and hangout in the tools-fivetran channel with us!

.github/ISSUE_TEMPLATE/feature-request.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: 🎉 Feature
22
description: Suggest a new feature for the Fivetran dbt package
33
title: "[Feature] <title>"
4-
labels: ["enhancement"]
4+
labels: ["type:enhancement"]
55
body:
66
- type: markdown
77
attributes:
@@ -20,6 +20,13 @@ body:
2020
description: A clear and concise description of what you want to happen and why you want the new feature.
2121
validations:
2222
required: true
23+
- type: textarea
24+
attributes:
25+
label: How would you implement this feature?
26+
description: |
27+
How would you build out this feature with your existing data? Any code examples you can provide to help accelerate development on this issue?
28+
validations:
29+
required: true
2330
- type: textarea
2431
attributes:
2532
label: Describe alternatives you've considered
@@ -34,7 +41,7 @@ body:
3441
description: Our team will assess this feature and let you know if we will add it to a future sprint. However, if you would like to expedite the feature, we encourage you to contribute to the package via a PR. Our team will then work with you to approve and merge your contributions as soon as possible.
3542
options:
3643
- label: Yes.
37-
- label: Yes, but I will need assistance and will schedule time during your [office hours](https://calendly.com/fivetran-solutions-team/fivetran-solutions-team-office-hours) for guidance.
44+
- label: Yes, but I will need assistance.
3845
- label: No.
3946
required: false
4047
- type: textarea

.github/PULL_REQUEST_TEMPLATE/maintainer_pull_request_template.md

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,19 @@
1111
### Basic Validation
1212
Please acknowledge that you have successfully performed the following commands locally:
1313
- [ ] dbt run –full-refresh && dbt test
14-
- [ ] dbt run (if incremental models are present)
14+
- [ ] dbt run (if incremental models are present) && dbt test
1515

1616
Before marking this PR as "ready for review" the following have been applied:
17-
- [ ] The appropriate issue has been linked, tagged, and properly assigned.
18-
- [ ] All necessary documentation and version upgrades have been applied.
19-
<!--- Be sre to update the package version in the dbt_project.yml, integration_tests/dbt_project.yml, and README if necessary. -->
20-
- [ ] docs were regenerated (unless this PR does not include any code or yml updates).
21-
- [ ] BuildKite integration tests are passing.
22-
- [ ] Detailed validation steps have been provided below.
17+
- [ ] The appropriate issue has been linked, tagged, and properly assigned
18+
- [ ] All necessary documentation and version upgrades have been applied
19+
- [ ] docs were regenerated (unless this PR does not include any code or yml updates)
20+
- [ ] BuildKite integration tests are passing
21+
- [ ] Detailed validation steps have been provided below
2322

2423
### Detailed Validation
2524
Please share any and all of your validation steps:
2625
<!--- Provide the steps you took to validate your changes below. -->
2726

2827
### If you had to summarize this PR in an emoji, which would it be?
2928
<!--- For a complete list of markdown compatible emojis check our this git repo (https://gist.github.com/rxaviers/7360908) -->
30-
:dancer:
29+
:dancer:

.github/pull_request_template.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,13 @@
1919
<!--- To select a checkbox you simply need to add an "x" with no spaces between the brackets (eg. [x] Yes). -->
2020
- [ ] Yes
2121

22-
**Provide an emoji that best describes your current mood**
22+
**Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?**
23+
<!--- If you select Yes this will help expedite your PR in case there are small changes required before approval. We encourage you not to use this branch in a production environment as we may make additional updates. -->
24+
<!--- If you select No, we will not make any changes directly to your branch and will either communicate any planned changes via the PR thread or will merge your PR into a separate branch so we may make changes without modifying your branch.. -->
25+
- [ ] Yes
26+
- [ ] No
27+
28+
**If you had to summarize this PR in an emoji, which would it be?**
2329
<!--- For a complete list of markdown compatible emojis check our this git repo (https://gist.github.com/rxaviers/7360908) -->
2430
:dancer:
2531

.github/workflows/auto-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ on:
99
jobs:
1010
call-workflow-passing-data:
1111
if: github.event.pull_request.merged
12-
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@feature/auto-releaser
12+
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main
1313
secrets: inherit

README.md

Lines changed: 28 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -12,47 +12,47 @@
1212

1313
# Sage Intacct Source dbt Package ([Docs](https://fivetran.github.io/dbt_sage_intacct_source/))
1414

15-
# 📣 What does this dbt package do?
15+
## What does this dbt package do?
1616
- Materializes [Sage Intacct staging tables](https://fivetran.github.io/dbt_sage_intacct_source/#!/overview/sage_intacct_source/models/?g_v=1&g_e=seeds) which leverage data in the format described by [this ERD](https://fivetran.com/docs/applications/sage-intacct#schemainformation). These staging tables clean, test, and prepare your Sage Intacct data from [Fivetran's connector](https://fivetran.com/docs/applications/sage-intacct) for analysis by doing the following:
17-
- Names columns for consistency across all packages and for easier analysis
18-
- Adds freshness tests to source data
19-
- Adds column-level testing where applicable. For example, all primary keys are tested for uniqueness and non-null values.
17+
- Names columns for consistency across all packages and for easier analysis
18+
- Adds freshness tests to source data
19+
- Adds column-level testing where applicable. For example, all primary keys are tested for uniqueness and non-null values.
2020
- Generates a comprehensive data dictionary of your sage_intacct data through the [dbt docs site](https://fivetran.github.io/dbt_sage_intacct_source/).
2121
- These tables are designed to work simultaneously with our [Sage Intacct transformation package](https://github.com/fivetran/dbt_sage_intacct).
22-
# 🎯 How do I use the dbt package?
23-
## Step 1: Prerequisites
22+
## How do I use the dbt package?
23+
### Step 1: Prerequisites
2424
To use this dbt package, you must have the following:
25-
- At least one Fivetran Sage Intacct connector syncing data into your destination.
25+
- At least one Fivetran Sage Intacct connector syncing data into your destination.
2626
- A **BigQuery**, **Snowflake**, **Redshift**, **PostgreSQL**, or **Databricks** destination.
2727

28-
### Databricks Dispatch Configuration
28+
#### Databricks Dispatch Configuration
2929
If you are using a Databricks destination with this package you will need to add the below (or a variation of the below) dispatch configuration within your `dbt_project.yml`. This is required in order for the package to accurately search for macros within the `dbt-labs/spark_utils` then the `dbt-labs/dbt_utils` packages respectively.
3030
```yml
3131
dispatch:
3232
- macro_namespace: dbt_utils
3333
search_order: ['spark_utils', 'dbt_utils']
3434
```
3535
36-
## Step 2: Install the package (skip if also using the `sage_intacct` transformation package)
37-
If you are **not** using the [Sage Intacct transformation package](https://github.com/fivetran/dbt_sage_intacct), include the following sage_intacct_source package version in your `packages.yml` file.
36+
### Step 2: Install the package (skip if also using the `sage_intacct` transformation package)
37+
If you are **not** using the [Sage Intacct transformation package](https://github.com/fivetran/dbt_sage_intacct), include the following sage_intacct_source package version in your `packages.yml` file.
3838
> TIP: Check [dbt Hub](https://hub.getdbt.com/) for the latest installation instructions or [read the dbt docs](https://docs.getdbt.com/docs/package-management) for more information on installing packages.
3939
```yaml
4040
packages:
4141
- package: fivetran/sage_intacct_source
4242
version: [">=0.3.0", "<0.4.0"] # we recommend using ranges to capture non-breaking changes automatically
4343
```
44-
## Step 3: Define database and schema variables
44+
### Step 3: Define database and schema variables
4545
By default, this package runs using your destination and the `sage_intacct` schema. If this is not where your Sage Intacct data is (for example, if your Sage Intacct schema is named `sage_intacct_fivetran`), add the following configuration to your root `dbt_project.yml` file:
4646

4747
```yml
4848
vars:
4949
sage_intacct_database: your_database_name
5050
sage_intacct_schema: your_schema_name
5151
```
52-
## (Optional) Step 4: Additional configurations
52+
### (Optional) Step 4: Additional configurations
5353

54-
### Passthrough Columns
55-
This package allows users to add additional columns to the `stg_sage_intacct__gl_account` table.
54+
#### Passthrough Columns
55+
This package allows users to add additional columns to the `stg_sage_intacct__gl_account` table.
5656
Columns passed through must be present in the upstream source tables. See below for an example of how the passthrough columns should be configured within your `dbt_project.yml` file.
5757

5858
```yml
@@ -65,7 +65,7 @@ vars:
6565
sage_gl_pass_through_columns: ['custom_field_3', 'custom_field_4']
6666
```
6767

68-
### Disabling and Enabling Models
68+
#### Disabling and Enabling Models
6969

7070
When setting up your Sage Intacct connection in Fivetran, it is possible that not every table this package expects will be synced. This can occur because you either don't use that functionality in Sage or have actively decided to not sync some tables. In order to disable the relevant functionality in the package, you will need to add the relevant variables.
7171

@@ -82,7 +82,7 @@ vars:
8282
```
8383

8484

85-
### Change the Build Schema
85+
#### Change the Build Schema
8686
By default, this package builds the Sage Intacct staging models within a schema titled (`<target_schema>` + `_stg_sage_intacct`) in your target database. If this is not where you would like your Sage Intacct staging data to be written to, add the following configuration to your `dbt_project.yml` file:
8787

8888
```yml
@@ -94,12 +94,12 @@ models:
9494
+schema: my_new_schema_name # leave blank for just the target_schema
9595
```
9696

97-
## (Optional) Step 5: Orchestrate your models with Fivetran Transformations for dbt Core™
97+
### (Optional) Step 5: Orchestrate your models with Fivetran Transformations for dbt Core™
9898
<details><summary>Expand for more details</summary>
9999

100100
Fivetran offers the ability for you to orchestrate your dbt project through [Fivetran Transformations for dbt Core™](https://fivetran.com/docs/transformations/dbt). Learn how to set up your project for orchestration through Fivetran in our [Transformations for dbt Core™ setup guides](https://fivetran.com/docs/transformations/dbt#setupguide).
101101

102-
### Change the source table references
102+
#### Change the source table references
103103
If an individual source table has a different name than the package expects, add the table name as it appears in your destination to the respective variable:
104104
> IMPORTANT: See this project's [`dbt_project.yml`](https://github.com/fivetran/dbt_sage_intacct_source/blob/main/dbt_project.yml) variable declarations to see the expected names.
105105

@@ -110,12 +110,12 @@ vars:
110110

111111
</details>
112112

113-
# 🙌 How is this package maintained and can I contribute?
114-
## Package Maintenance
113+
## How is this package maintained and can I contribute?
114+
### Package Maintenance
115115
The Fivetran team maintaining this package _only_ maintains the latest version of the package. We highly recommend that you stay consistent with the [latest version](https://hub.getdbt.com/fivetran/sage_intacct_source/latest/) of the package and refer to the [CHANGELOG](https://github.com/fivetran/dbt_sage_intacct_source/blob/main/CHANGELOG.md) and release notes for more information on changes across versions.
116116

117-
# 🔍 Does this package have dependencies?
118-
This dbt package is dependent on the following dbt packages. Please be aware that these dependencies are installed by default within this package. For more information on the following packages, refer to the [dbt hub](https://hub.getdbt.com/) site.
117+
## Does this package have dependencies?
118+
This dbt package is dependent on the following dbt packages. These dependencies are installed by default within this package. For more information on the following packages, refer to the [dbt hub](https://hub.getdbt.com/) site.
119119
> IMPORTANT: If you have any of these dependent packages in your own `packages.yml` file, we highly recommend that you remove them from your root `packages.yml` to avoid package version conflicts.
120120
```yml
121121
packages:
@@ -129,12 +129,11 @@ packages:
129129
version: [">=0.3.0", "<0.4.0"]
130130
```
131131

132-
## Contributions
133-
A small team of analytics engineers at Fivetran develops these dbt packages. However, the packages are made better by community contributions!
132+
### Contributions
133+
A small team of analytics engineers at Fivetran develops these dbt packages. However, the packages are made better by community contributions.
134134

135-
We highly encourage and welcome contributions to this package. Check out [this dbt Discourse article](https://discourse.getdbt.com/t/contributing-to-a-dbt-package/657) to learn how to contribute to a dbt package!
135+
We highly encourage and welcome contributions to this package. Check out [this dbt Discourse article](https://discourse.getdbt.com/t/contributing-to-a-dbt-package/657) to learn how to contribute to a dbt package.
136136

137-
# 🏪 Are there any resources available?
138-
- If you have questions or want to reach out for help, please refer to the [GitHub Issue](https://github.com/fivetran/dbt_sage_intacct_source/issues/new/choose) section to find the right avenue of support for you.
139-
- If you would like to provide feedback to the dbt package team at Fivetran or would like to request a new dbt package, fill out our [Feedback Form](https://www.surveymonkey.com/r/DQ7K7WW).
140-
- Have questions or want to just say hi? Book a time during our office hours [on Calendly](https://calendly.com/fivetran-solutions-team/fivetran-solutions-team-office-hours) or email us at solutions@fivetran.com.
137+
## Are there any resources available?
138+
- If you have questions or want to reach out for help, see the [GitHub Issue](https://github.com/fivetran/dbt_sage_intacct_source/issues/new/choose) section to find the right avenue of support for you.
139+
- If you would like to provide feedback to the dbt package team at Fivetran or would like to request a new dbt package, fill out our [Feedback Form](https://www.surveymonkey.com/r/DQ7K7WW).

0 commit comments

Comments
 (0)