Skip to content

Commit 78b6109

Browse files
Merge pull request #12 from fivetran/bugfix/cast_dept_id_as_string
Bugfix/cast dept id as string
2 parents c1485c6 + 3ad3a57 commit 78b6109

11 files changed

+46
-33
lines changed

CHANGELOG.md

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
1-
# dbt_sage_intacct_source v0.UPDATE.UPDATE
1+
# dbt_sage_intacct_source v0.2.1
22

3-
## Under the Hood:
4-
- Incorporated the new `fivetran_utils.drop_schemas_automation` macro into the end of each Buildkite integration test job.
5-
- Updated the pull request [templates](/.github).
3+
A very spoooOOOOOooooky release 🎃 👻
4+
5+
## Bug Fixes
6+
- Explicitly casts `department_id`, `location_id`, and `item_id` as strings in the staging `ap_bill_item` and `ar_invoice_item` models, which are unioned together downstream in [`sage_intacct_ap_ar_enhanced`](https://fivetran.github.io/dbt_sage_intacct/#!/model/model.sage_intacct.sage_intacct__ap_ar_enhanced) ([PR #12](https://github.com/fivetran/dbt_sage_intacct_source/pull/12)).
7+
8+
## Under the Hood:
9+
- Incorporated the new `fivetran_utils.drop_schemas_automation` macro into the end of each Buildkite integration test job ([PR #11](https://github.com/fivetran/dbt_sage_intacct_source/pull/11)).
10+
- Updated the pull request [templates](/.github) ([PR #11](https://github.com/fivetran/dbt_sage_intacct_source/pull/11)).
611

712
# dbt_sage_intacct_source v0.2.0
813

@@ -72,6 +77,16 @@ Thank you @santi95 for raising these to our attention! ([#6](https://github.com/
7277

7378
# dbt_sage_intacct_source v0.1.0
7479

75-
## Initial Release
76-
- This is the initial release of this package. For more information refer to the [README](/README.md).
80+
# 🎉 Initial Release 🎉
81+
- This is the initial release of this package.
82+
83+
This package is designed enrich your Fivetran data by doing the following:
84+
85+
- Add descriptions to tables and columns that are synced using Fivetran
86+
- Add freshness tests to source data
87+
- Add column-level testing where applicable. For example, all primary keys are tested for uniqueness and non-null values.
88+
- Model staging tables, which will be used in our transform package
89+
90+
Currently the package supports Postgres, Redshift, BigQuery, Databricks and Snowflake. Additionally, this package is designed to work with dbt versions [">=1.0.0", "<2.0.0"].
7791

92+
- For more information refer to the [README](/README.md).

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ vars:
5050
sage_intacct_schema: your_schema_name
5151
```
5252
## (Optional) Step 4: Additional configurations
53-
<details><summary>Expand for configurations</summary>
5453

5554
### Passthrough Columns
5655
This package allows users to add additional columns to the `stg_sage_intacct__gl_account` table.
@@ -95,8 +94,6 @@ models:
9594
+schema: my_new_schema_name # leave blank for just the target_schema
9695
```
9796

98-
</details>
99-
10097
## (Optional) Step 5: Orchestrate your models with Fivetran Transformations for dbt Core™
10198
<details><summary>Expand for more details</summary>
10299

dbt_project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 'sage_intacct_source'
2-
version: '0.2.0'
2+
version: '0.2.1'
33
config-version: 2
44
require-dbt-version: [">=1.3.0", "<2.0.0"]
55
models:

docs/catalog.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

docs/index.html

Lines changed: 12 additions & 12 deletions
Large diffs are not rendered by default.

docs/manifest.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

docs/run_results.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

integration_tests/dbt_project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

22
name: 'sage_intacct_source_integration_tests'
3-
version: '0.2.0'
3+
version: '0.2.1'
44
config-version: 2
55

66
profile: 'integration_tests'

integration_tests/requirements.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ dbt-redshift>=1.3.0,<1.5.0
44
dbt-postgres>=1.3.0,<2.0.0
55
dbt-spark>=1.3.0,<2.0.0
66
dbt-spark[PyHive]>=1.3.0,<2.0.0
7-
dbt-databricks>=1.3.0,<2.0.0
7+
dbt-databricks>=1.3.0,<2.0.0
8+
oscrypto @ git+https://github.com/wbond/oscrypto.git@d5f3437

models/stg_sage_intacct__ap_bill_item.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,16 @@ final as (
4040
currency,
4141
customerid as customer_id,
4242
customername as customer_name,
43-
departmentid as department_id,
43+
cast(departmentid as {{ dbt.type_string() }}) as department_id,
4444
departmentname as department_name,
4545
entry_date as entry_date_at,
4646
entrydescription as entry_description,
4747
exchange_rate,
48-
itemid as item_id,
48+
cast(itemid as {{ dbt.type_string() }}) as item_id,
4949
itemname as item_name,
5050
line_no,
5151
lineitem as line_item,
52-
locationid as location_id,
52+
cast(locationid as {{ dbt.type_string() }}) as location_id,
5353
locationname as location_name,
5454
offsetglaccountno as offset_gl_account_no,
5555
offsetglaccounttitle as offset_gl_account_title,

0 commit comments

Comments
 (0)