Skip to content

Commit a0357d4

Browse files
fivetran-jamieb-perfivetran-avinash
authored
Dbt engine compat for fusion (#22)
* Fix deprecations for new dbt engine compatibility (#21) Merging into a working branch that will be shortly merged and released to main * polishes * Update CHANGELOG.md Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com> --------- Co-authored-by: Benoit Perigaud <8754100+b-per@users.noreply.github.com> Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
1 parent e34b93e commit a0357d4

File tree

8 files changed

+57
-67
lines changed

8 files changed

+57
-67
lines changed
Lines changed: 29 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,35 @@
1-
## PR Overview
2-
**This PR will address the following Issue/Feature:**
1+
<!--
2+
Pre-Submission Reminders
3+
Before marking this PR as "ready for review":
34
4-
**This PR will result in the following new package version:**
5-
<!--- Please add details around your decision for breaking vs non-breaking version upgrade. If this is a breaking change, were backwards-compatible options explored? -->
5+
- `dbt run --full-refresh && dbt test`
6+
- `dbt run` && `dbt test` (if incremental models are present)
7+
- The related issue is linked, tagged, and appropriately assigned
8+
- Documentation and version updates are included, if applicable
9+
- `docs` have been regenerated (unless there are no code or YAML changes)
10+
- BuildKite integration tests are passing
11+
-->
612

7-
**Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:**
8-
<!--- Copy/paste the CHANGELOG for this version below. -->
13+
## PR Overview
14+
**Package version introduced in this PR:**
15+
16+
**This PR addresses the following Issue/Feature(s):**
17+
<!-- Add Issue # or internal ticket reference -->
918

10-
## PR Checklist
11-
### Basic Validation
12-
Please acknowledge that you have successfully performed the following commands locally:
13-
- [ ] dbt run –full-refresh && dbt test
14-
- [ ] dbt run (if incremental models are present) && dbt test
19+
**Summary of changes:**
20+
<!-- 1-2 sentences describing PR changes. -->
1521

16-
Before marking this PR as "ready for review" the following have been applied:
17-
- [ ] The appropriate issue has been linked, tagged, and properly assigned
18-
- [ ] All necessary documentation and version upgrades have been applied
19-
- [ ] docs were regenerated (unless this PR does not include any code or yml updates)
20-
- [ ] BuildKite integration tests are passing
21-
- [ ] Detailed validation steps have been provided below
2222

23-
### Detailed Validation
24-
Please share any and all of your validation steps:
25-
<!--- Provide the steps you took to validate your changes below. -->
23+
### Submission Checklist
24+
- [ ] Alignment meeting with the reviewer (if needed)
25+
- [ ] Timeline and validation requirements discussed
26+
- [ ] Provide validation details:
27+
- [ ] **Validation Steps:** Check for unintentional effects (e.g., add/run consistency & integrity tests)
28+
- [ ] **Testing Instructions:** Confirm the change addresses the issue(s)
29+
- [ ] **Focus Areas:** Complex logic or queries that need extra attention
2630

27-
### If you had to summarize this PR in an emoji, which would it be?
28-
<!--- For a complete list of markdown compatible emojis check our this git repo (https://gist.github.com/rxaviers/7360908) -->
29-
:dancer:
31+
### Changelog
32+
<!-- Recommend drafting changelog notes, then refining via ChatGPT using:
33+
"Draft a changelog entry based on the following notes." -->
34+
- [ ] Draft changelog for PR
35+
- [ ] Final changelog for release review

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
# dbt_sage_intacct_source v0.4.1
2+
This release includes the following updates:
3+
4+
## Under the Hood
5+
- Prepends `materialized` configs in the package's `dbt_project.yml` file with `+` to improve compatibility with the newer versions of dbt-core starting with v1.10.0. ([PR #21](https://github.com/fivetran/dbt_sage_intacct_source/pull/21))
6+
- Updates the package maintainer pull request template. ([PR #22](https://github.com/fivetran/dbt_sage_intacct_source/pull/22))
7+
8+
## Contributors
9+
- [@b-per](https://github.com/b-per) ([PR #21](https://github.com/fivetran/dbt_sage_intacct_source/pull/21))
10+
111
# dbt_sage_intacct_source v0.4.0
212
[PR #20](https://github.com/fivetran/dbt_sage_intacct_source/pull/20) includes the following updates:
313

dbt_project.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
name: 'sage_intacct_source'
2-
version: '0.4.0'
2+
version: '0.4.1'
33
config-version: 2
44
require-dbt-version: [">=1.3.0", "<2.0.0"]
55
models:
66
sage_intacct_source:
77
+schema: sage_intacct_staging
8-
materialized: table
8+
+materialized: table
99
tmp:
10-
materialized: view
10+
+materialized: view
1111
vars:
1212
sage_intacct_source:
1313
gl_detail: "{{ source('sage_intacct','gl_detail') }}"

docs/catalog.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

docs/index.html

Lines changed: 10 additions & 37 deletions
Large diffs are not rendered by default.

docs/manifest.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

integration_tests/dbt_project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 'sage_intacct_source_integration_tests'
2-
version: '0.4.0'
2+
version: '0.4.1'
33
config-version: 2
44

55
profile: 'integration_tests'

integration_tests/requirements.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,5 @@ dbt-redshift>=1.3.0,<2.0.0
44
dbt-postgres>=1.3.0,<2.0.0
55
dbt-spark>=1.3.0,<2.0.0
66
dbt-spark[PyHive]>=1.3.0,<2.0.0
7-
dbt-databricks>=1.6.0,<2.0.0
7+
dbt-databricks>=1.6.0,<2.0.0
8+
certifi==2025.1.31

0 commit comments

Comments
 (0)