Skip to content

Commit 55bf9bc

Browse files
committed
Support any kind of keyword for callbacks.
1 parent 9cda898 commit 55bf9bc

File tree

1 file changed

+11
-27
lines changed

1 file changed

+11
-27
lines changed

run/run.go

Lines changed: 11 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -334,33 +334,22 @@ func BooleanCallback(
334334
return
335335
}
336336

337-
actConfirm, _ := childrenDescr.Get(submitName)
338-
if actConfirm == nil {
339-
log.Printf("ERROR: for %q: %q action is missing", fullName, submitName)
337+
keySubmit, _ := childrenDescr.Get(submitName)
338+
if keySubmit == nil {
339+
log.Printf("ERROR: for %q: %q keyword is missing", fullName, submitName)
340340
return defaultCallback
341341
}
342-
keyword := actConfirm[ui.AttrKeyword].(string)
343-
if keyword != ui.KeywordAction {
344-
log.Printf("ERROR: for %q: %q action is not an action but a %q", fullName, submitName, keyword)
345-
return defaultCallback
346-
}
347-
348-
actDismiss, _ := childrenDescr.Get(cancelName)
349-
if actDismiss == nil {
350-
log.Printf("ERROR: for %q: %q action is missing", fullName, cancelName)
351-
return defaultCallback
352-
}
353-
keyword = actDismiss[ui.AttrKeyword].(string)
354-
if keyword != ui.KeywordAction {
355-
log.Printf("ERROR: for %q: %q action is not an action but a %q", fullName, cancelName, keyword)
342+
keyCancel, _ := childrenDescr.Get(cancelName)
343+
if keyCancel == nil {
344+
log.Printf("ERROR: for %q: %q keyword is missing", fullName, cancelName)
356345
return defaultCallback
357346
}
358347

359348
return func(submitted bool) {
360349
if submitted {
361-
Action(actConfirm, ui.FullNameFor(fullName, submitName), win, uiDescr)
350+
Keyword(keySubmit, ui.FullNameFor(fullName, submitName), win, uiDescr)
362351
} else {
363-
Action(actDismiss, ui.FullNameFor(fullName, cancelName), win, uiDescr)
352+
Keyword(keyCancel, ui.FullNameFor(fullName, cancelName), win, uiDescr)
364353
}
365354
}
366355
}
@@ -369,18 +358,13 @@ func CloseCallback(childDescr ui.CommandsDescr, fullName string, win fyne.Window
369358
defaultCallback := func() {
370359
return
371360
}
372-
actClose, _ := childDescr.Get("close")
373-
if actClose == nil { // action is optional
374-
return defaultCallback
375-
}
376-
keyword := actClose[ui.AttrKeyword].(string)
377-
if keyword != ui.KeywordAction {
378-
log.Printf("ERROR: for %q: close action is not an action but a %q", fullName, keyword)
361+
keyClose, _ := childDescr.Get("close")
362+
if keyClose == nil { // action is optional
379363
return defaultCallback
380364
}
381365

382366
return func() {
383-
Action(actClose, ui.FullNameFor(fullName, "close"), win, uiDescr)
367+
Keyword(keyClose, ui.FullNameFor(fullName, "close"), win, uiDescr)
384368
}
385369
}
386370

0 commit comments

Comments
 (0)