Creating 'utils.get_socket' and 'utils.get_address' for reusing these common functions. Using them in rdp_check

Author: gabrielg5

examples/rdp_check.py

@@ -25,7 +25,7 @@
 from struct import pack, unpack
 
 from impacket.examples import logger
-from impacket.examples.utils import parse_target
+from impacket.examples.utils import parse_target, get_socket
 from impacket.structure import Structure
 from impacket.spnego import GSSAPI, ASN1_SEQUENCE, ASN1_OCTET_STRING, asn1decode, asn1encode
 
@@ -383,17 +383,7 @@ def check_rdp(host, username, password, domain, hashes=None, ipv6=False):
        tpdu['Code'] = TDPU_CONNECTION_REQUEST
        tpkt['TPDU'] = tpdu.getData()
 
-       address = (host, 3389)
-       if ipv6:
-            s = socket.socket(socket.AF_INET6)
-            # scope_id (after %) can be present or not - if not, default: 0
-            host_ipv6_parts = host.split('%')
-            scope_id = int(host_ipv6_parts[1]) if len(host_ipv6_parts) == 2 else 0
-            address = address + (0, scope_id)
-       else:
-            s = socket.socket()
-
-       s.connect(address)
+       s = get_socket(host, 3389, ipv6)
        s.sendall(tpkt.getData())
        pkt = s.recv(8192)
        tpkt.fromString(pkt)

impacket/examples/utils.py

@@ -317,3 +317,21 @@ def parse_identity(credentials, hashes=None, no_pass=False, aesKey=None, k=False
             lmhash = EMPTY_LM_HASH
 
     return domain, username, password, lmhash, nthash, k
+
+# ----------
+
+def get_address(ip, port, ipv6=False):
+    address = (ip, port)
+    if ipv6:
+        # scope_id (after %) can be present or not - if not, default: 0
+        ip_parts = ip.split('%')
+        scope_id = int(ip_parts[1]) if len(ip_parts) == 2 else 0
+        address = address + (0, scope_id)
+    return address
+
+import socket
+def get_socket(ip, port, ipv6=False):
+    s = socket.socket(socket.AF_INET6 if ipv6 else socket.AF_INET)
+    address = get_address(ip, port, ipv6)
+    s.connect(address)
+    return s