Skip to content

Commit c0771d8

Browse files
jsihvolamhorne
authored andcommitted
jh7110_pcie.c: add empty PIC methods to conform conventions
This commit updates the driver code to conform with an undocumented convention which says that certain functions need always be implemented together regardless of their content (or lack of). It's been said that unimplemented KOBJ methods become stubs which return ENXIO so this commit does not imply a functional change. Reviewed by: mhorne Differential Revision: https://reviews.freebsd.org/D52042
1 parent 84f8ca1 commit c0771d8

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

sys/riscv/starfive/jh7110_pcie.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -482,6 +482,16 @@ jh7110_pcie_msi_enable_intr(device_t dev, struct intr_irqsrc *isrc)
482482
jh7110_pcie_msi_mask(dev, isrc, false);
483483
}
484484

485+
static void
486+
jh7110_pcie_msi_post_filter(device_t dev, struct intr_irqsrc *isrc)
487+
{
488+
}
489+
490+
static void
491+
jh7110_pcie_msi_post_ithread(device_t dev, struct intr_irqsrc *isrc)
492+
{
493+
}
494+
485495
static void
486496
jh7110_pcie_msi_pre_ithread(device_t dev, struct intr_irqsrc *isrc)
487497
{
@@ -1008,6 +1018,8 @@ static device_method_t jh7110_pcie_methods[] = {
10081018
/* Interrupt controller interface */
10091019
DEVMETHOD(pic_enable_intr, jh7110_pcie_msi_enable_intr),
10101020
DEVMETHOD(pic_disable_intr, jh7110_pcie_msi_disable_intr),
1021+
DEVMETHOD(pic_post_filter, jh7110_pcie_msi_post_filter),
1022+
DEVMETHOD(pic_post_ithread, jh7110_pcie_msi_post_ithread),
10111023
DEVMETHOD(pic_pre_ithread, jh7110_pcie_msi_pre_ithread),
10121024

10131025
/* OFW bus interface */

0 commit comments

Comments
 (0)