Skip to content

Commit d789613

Browse files
author
Elijah Rappaport
committed
fix naming: HTTPVerb ==> HTTPMethod
1 parent 37c21d8 commit d789613

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

Sources/Networking/Calls/NetworkingClient+Requests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ public extension NetworkingClient {
3030
request(.delete, route, params: params)
3131
}
3232

33-
internal func request(_ httpVerb: HTTPVerb, _ route: String, params: Params = Params()) -> NetworkingRequest {
33+
internal func request(_ httpMethod: HTTPMethod, _ route: String, params: Params = Params()) -> NetworkingRequest {
3434
let req = NetworkingRequest()
35-
req.httpVerb = httpVerb
35+
req.httpMethod = httpMethod
3636
req.route = route
3737
req.params = params
3838

Sources/Networking/HTTPVerb.swift renamed to Sources/Networking/HTTPMethod.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
//
2-
// HTTPVerb.swift
2+
// HTTPMethod.swift
33
//
44
//
55
// Created by Sacha DSO on 30/01/2020.
66
//
77

88
import Foundation
99

10-
public enum HTTPVerb: String {
10+
public enum HTTPMethod: String {
1111
case get = "GET"
1212
case put = "PUT"
1313
case patch = "PATCH"

Sources/Networking/Logging/NetworkingLogger.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ class NetworkingLogger {
1515
guard logLevel != .off else {
1616
return
1717
}
18-
if let verb = request.httpMethod,
18+
if let method = request.httpMethod,
1919
let url = request.url {
20-
print("\(verb) '\(url.absoluteString)'")
20+
print("\(method) '\(url.absoluteString)'")
2121
logHeaders(request)
2222
logBody(request)
2323

Sources/Networking/NetworkingRequest.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class NetworkingRequest: NSObject {
1515
var parameterEncoding = ParameterEncoding.urlEncoded
1616
var baseURL = ""
1717
var route = ""
18-
var httpVerb = HTTPVerb.get
18+
var httpMethod = HTTPMethod.get
1919
public var params = Params()
2020
var headers = [String: String]()
2121
var multipartData: [MultipartData]?
@@ -137,7 +137,7 @@ public class NetworkingRequest: NSObject {
137137

138138
internal func buildURLRequest() -> URLRequest? {
139139
var urlString = baseURL + route
140-
if httpVerb == .get {
140+
if httpMethod == .get {
141141
urlString = getURLWithParams()
142142
}
143143

@@ -146,7 +146,7 @@ public class NetworkingRequest: NSObject {
146146
}
147147
var request = URLRequest(url: url)
148148

149-
if httpVerb != .get && multipartData == nil {
149+
if httpMethod != .get && multipartData == nil {
150150
switch parameterEncoding {
151151
case .urlEncoded:
152152
request.setValue("application/x-www-form-urlencoded", forHTTPHeaderField: "Content-Type")
@@ -155,7 +155,7 @@ public class NetworkingRequest: NSObject {
155155
}
156156
}
157157

158-
request.httpMethod = httpVerb.rawValue
158+
request.httpMethod = httpMethod.rawValue
159159
for (key, value) in headers {
160160
request.setValue(value, forHTTPHeaderField: key)
161161
}
@@ -164,7 +164,7 @@ public class NetworkingRequest: NSObject {
164164
request.timeoutInterval = timeout
165165
}
166166

167-
if httpVerb != .get && multipartData == nil {
167+
if httpMethod != .get && multipartData == nil {
168168
switch parameterEncoding {
169169
case .urlEncoded:
170170
request.httpBody = params.asPercentEncodedString().data(using: .utf8)

0 commit comments

Comments
 (0)