Lift requirement of setting REST Client base URL when mocks are used

Closes: quarkusio#47383

Author: geoand

extensions/resteasy-reactive/rest-client/deployment/src/main/java/io/quarkus/rest/client/reactive/deployment/RestClientReactiveProcessor.java

@@ -28,13 +28,15 @@
 import java.lang.reflect.Modifier;
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
 import java.util.function.Predicate;
+import java.util.stream.Collectors;
 
 import jakarta.enterprise.context.SessionScoped;
 import jakarta.enterprise.inject.Typed;
@@ -87,6 +89,7 @@
 import io.quarkus.deployment.builditem.ExtensionSslNativeSupportBuildItem;
 import io.quarkus.deployment.builditem.FeatureBuildItem;
 import io.quarkus.deployment.builditem.GeneratedClassBuildItem;
+import io.quarkus.deployment.builditem.LaunchModeBuildItem;
 import io.quarkus.deployment.builditem.RunTimeConfigBuilderBuildItem;
 import io.quarkus.deployment.builditem.ShutdownContextBuildItem;
 import io.quarkus.deployment.builditem.StaticInitConfigBuilderBuildItem;
@@ -119,7 +122,9 @@ class RestClientReactiveProcessor {
     private static final Logger log = Logger.getLogger(RestClientReactiveProcessor.class);
 
     private static final DotName REGISTER_REST_CLIENT = DotName.createSimple(RegisterRestClient.class.getName());
+    private static final DotName REST_CLIENT = DotName.createSimple(RestClient.class.getName());
     private static final DotName SESSION_SCOPED = DotName.createSimple(SessionScoped.class.getName());
+    private static final DotName INJECT_MOCK = DotName.createSimple("io.quarkus.test.InjectMock");
     private static final DotName KOTLIN_METADATA_ANNOTATION = DotName.createSimple("kotlin.Metadata");
 
     private static final String ENABLE_COMPRESSION = "quarkus.http.enable-compression";
@@ -473,11 +478,24 @@ void addRestClientBeans(Capabilities capabilities,
             BuildProducer<GeneratedBeanBuildItem> generatedBeans,
             RestClientReactiveConfig clientConfig,
             RestClientsBuildTimeConfig clientsBuildConfig,
+            LaunchModeBuildItem launchMode,
             RestClientRecorder recorder,
             ShutdownContextBuildItem shutdown) {
 
         CompositeIndex index = CompositeIndex.create(combinedIndexBuildItem.getIndex());
 
+        Set<DotName> requestedRestClientMocks = Collections.emptySet();
+        if (launchMode.getLaunchMode() == LaunchMode.TEST) {
+            // we need to determine which RestClient interfaces have been marked for mocking
+            requestedRestClientMocks = combinedIndexBuildItem.getIndex().getAnnotations(INJECT_MOCK)
+                    .stream()
+                    .filter(ai -> ai.target().kind() == AnnotationTarget.Kind.FIELD)
+                    .map(ai -> ai.target().asField())
+                    .filter(f -> f.hasAnnotation(REST_CLIENT))
+                    .map(f -> f.type().name())
+                    .collect(Collectors.toSet());
+        }
+
         Map<String, String> configKeys = new HashMap<>();
         var annotationsStore = new AnnotationStore(index, restClientAnnotationsTransformerBuildItem.stream()
                 .map(RestClientAnnotationsTransformerBuildItem::getAnnotationTransformation).toList());
@@ -552,14 +570,16 @@ void addRestClientBeans(Capabilities capabilities,
                 Optional<String> baseUri = registerRestClient.getDefaultBaseUri();
 
                 ResultHandle baseUriHandle = constructor.load(baseUri.isPresent() ? baseUri.get() : "");
+                boolean lazyDelegate = scope.getDotName().equals(REQUEST_SCOPED)
+                        || requestedRestClientMocks.contains(jaxrsInterface.name());
                 constructor.invokeSpecialMethod(
                         MethodDescriptor.ofConstructor(RestClientReactiveCDIWrapperBase.class, Class.class, String.class,
                                 String.class, boolean.class),
                         constructor.getThis(),
                         constructor.loadClassFromTCCL(jaxrsInterface.toString()),
                         baseUriHandle,
                         configKey.isPresent() ? constructor.load(configKey.get()) : constructor.loadNull(),
-                        constructor.load(scope.getDotName().equals(REQUEST_SCOPED)));
+                        constructor.load(lazyDelegate));
                 constructor.returnValue(null);
 
                 // METHODS:

extensions/resteasy-reactive/rest-client/runtime/src/main/java/io/quarkus/rest/client/reactive/runtime/RestClientReactiveCDIWrapperBase.java

@@ -21,13 +21,12 @@ public abstract class RestClientReactiveCDIWrapperBase<T extends Closeable> impl
     private Object mock;
 
     public RestClientReactiveCDIWrapperBase(Class<T> jaxrsInterface, String baseUriFromAnnotation,
-            String configKey, boolean requestScope) {
+            String configKey, boolean lazyDelegate) {
         this.jaxrsInterface = jaxrsInterface;
         this.baseUriFromAnnotation = baseUriFromAnnotation;
         this.configKey = configKey;
-        if (!requestScope) {
-            // when not using the Request scope, we eagerly create the delegate
-            delegate();
+        if (!lazyDelegate) {
+            constructDelegate();
         }
     }
 
@@ -55,7 +54,7 @@ public void destroy() {
     @SuppressWarnings("unused")
     @NoClassInterceptors
     public Object getDelegate() {
-        return mock == null ? delegate() : mock;
+        return mock == null ? constructDelegate() : mock;
     }
 
     @Override
@@ -71,7 +70,7 @@ public void clearMock() {
     }
 
     @NoClassInterceptors
-    private T delegate() {
+    private T constructDelegate() {
         if (delegate == null) {
             delegate = RestClientCDIDelegateBuilder.createDelegate(jaxrsInterface, baseUriFromAnnotation, configKey);
         }

integration-tests/rest-client-reactive/src/main/java/io/quarkus/it/rest/client/main/FaultToleranceOnInterfaceClient.java

@@ -12,7 +12,7 @@
 import org.eclipse.microprofile.rest.client.inject.RegisterRestClient;
 
 @Path("/unprocessable")
-@RegisterRestClient(configKey = "w-fault-tolerance")
+@RegisterRestClient(configKey = "w-fault-tolerance-int")
 @CircuitBreaker(requestVolumeThreshold = 2, delay = 1, delayUnit = ChronoUnit.MINUTES)
 public interface FaultToleranceOnInterfaceClient {
     @GET

integration-tests/rest-client-reactive/src/test/java/io/quarkus/it/rest/client/InjectMockTest.java

@@ -11,8 +11,8 @@
 
 import io.quarkus.it.rest.client.main.ClientWithExceptionMapper;
 import io.quarkus.it.rest.client.main.MyResponseExceptionMapper;
+import io.quarkus.test.InjectMock;
 import io.quarkus.test.junit.QuarkusTest;
-import io.quarkus.test.junit.mockito.InjectMock;
 import io.restassured.RestAssured;
 
 @QuarkusTest

integration-tests/rest-client-reactive/src/test/java/io/quarkus/it/rest/client/InjectMockWithInterceptorTest.java

@@ -12,8 +12,8 @@
 import org.junit.jupiter.api.Test;
 
 import io.quarkus.it.rest.client.main.FaultToleranceOnInterfaceClient;
+import io.quarkus.test.InjectMock;
 import io.quarkus.test.junit.QuarkusTest;
-import io.quarkus.test.junit.mockito.InjectMock;
 import io.restassured.RestAssured;
 import io.smallrye.faulttolerance.api.CircuitBreakerMaintenance;