Skip to content

Commit 948d7d5

Browse files
authored
fix(python): Comment out emscripten wheel build (#1209)
Not currently working and not a priority, sorry to say 🥲 Closes #1208
1 parent 20359f5 commit 948d7d5

File tree

1 file changed

+40
-40
lines changed

1 file changed

+40
-40
lines changed

.github/workflows/python-core-wheels.yml

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -151,45 +151,45 @@ jobs:
151151
name: wheels-macos-${{ matrix.platform.target }}-${{ matrix.module }}
152152
path: dist
153153

154-
emscripten:
155-
runs-on: ${{ matrix.platform.runner }}
156-
strategy:
157-
matrix:
158-
platform:
159-
- runner: ubuntu-latest
160-
target: wasm32-unknown-emscripten
161-
module:
162-
- geoarrow-core
163-
- geoarrow-compute
164-
steps:
165-
- uses: actions/checkout@v4
166-
- run: pip install pyodide-build
167-
- name: Get Emscripten and Python version info
168-
shell: bash
169-
run: |
170-
echo EMSCRIPTEN_VERSION=$(pyodide config get emscripten_version) >> $GITHUB_ENV
171-
echo PYTHON_VERSION=$(pyodide config get python_version | cut -d '.' -f 1-2) >> $GITHUB_ENV
172-
pip uninstall -y pyodide-build
173-
- uses: mymindstorm/setup-emsdk@v14
174-
with:
175-
version: ${{ env.EMSCRIPTEN_VERSION }}
176-
actions-cache-folder: emsdk-cache
177-
- uses: actions/setup-python@v5
178-
with:
179-
python-version: ${{ env.PYTHON_VERSION }}
180-
- run: pip install pyodide-build
181-
- name: Build wheels
182-
uses: PyO3/maturin-action@v1
183-
with:
184-
rust-toolchain: nightly
185-
target: ${{ matrix.platform.target }}
186-
args: --release --out dist -i 3.9 -i 3.10 -i 3.11 -i 3.12 -i 3.13 --no-default-features --manifest-path python/${{ matrix.module }}/Cargo.toml
187-
sccache: "true"
188-
- name: Upload wheels
189-
uses: actions/upload-artifact@v4
190-
with:
191-
name: wasm-wheels-${{ matrix.module }}
192-
path: dist
154+
# emscripten:
155+
# runs-on: ${{ matrix.platform.runner }}
156+
# strategy:
157+
# matrix:
158+
# platform:
159+
# - runner: ubuntu-latest
160+
# target: wasm32-unknown-emscripten
161+
# module:
162+
# - geoarrow-core
163+
# - geoarrow-compute
164+
# steps:
165+
# - uses: actions/checkout@v4
166+
# - run: pip install pyodide-build
167+
# - name: Get Emscripten and Python version info
168+
# shell: bash
169+
# run: |
170+
# echo EMSCRIPTEN_VERSION=$(pyodide config get emscripten_version) >> $GITHUB_ENV
171+
# echo PYTHON_VERSION=$(pyodide config get python_version | cut -d '.' -f 1-2) >> $GITHUB_ENV
172+
# pip uninstall -y pyodide-build
173+
# - uses: mymindstorm/setup-emsdk@v14
174+
# with:
175+
# version: ${{ env.EMSCRIPTEN_VERSION }}
176+
# actions-cache-folder: emsdk-cache
177+
# - uses: actions/setup-python@v5
178+
# with:
179+
# python-version: ${{ env.PYTHON_VERSION }}
180+
# - run: pip install pyodide-build
181+
# - name: Build wheels
182+
# uses: PyO3/maturin-action@v1
183+
# with:
184+
# rust-toolchain: nightly
185+
# target: ${{ matrix.platform.target }}
186+
# args: --release --out dist -i 3.9 -i 3.10 -i 3.11 -i 3.12 -i 3.13 --no-default-features --manifest-path python/${{ matrix.module }}/Cargo.toml
187+
# sccache: "true"
188+
# - name: Upload wheels
189+
# uses: actions/upload-artifact@v4
190+
# with:
191+
# name: wasm-wheels-${{ matrix.module }}
192+
# path: dist
193193

194194
# sdist:
195195
# runs-on: ubuntu-latest
@@ -209,7 +209,7 @@ jobs:
209209
release:
210210
name: Release
211211
runs-on: ubuntu-latest
212-
if: "startsWith(github.ref, 'refs/tags/')"
212+
if: startsWith(github.ref, 'refs/tags/')
213213
needs: [linux, windows, macos]
214214
permissions:
215215
# Used to upload release artifacts

0 commit comments

Comments
 (0)