From dd88de1be9a674d8eb4b1bfad53b2bdd82ca7efc Mon Sep 17 00:00:00 2001 From: cmoinier Date: Thu, 21 Aug 2025 11:40:36 +0200 Subject: [PATCH 1/2] feat: hide keywords when over 4 lines of badges --- .../src/lib/metadata-info/metadata-info.component.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.html b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.html index dc33089c64..1439fa5628 100644 --- a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.html +++ b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.html @@ -24,7 +24,7 @@ ghostClass="h-[31px] w-3/4" [showContent]="fieldReady('keywords')" > -
+ -
+ From 80f5ed314f7d68a0452d0aefa1a3061fcb554509 Mon Sep 17 00:00:00 2001 From: cmoinier Date: Fri, 22 Aug 2025 11:01:31 +0200 Subject: [PATCH 2/2] fix e2e tests --- apps/datahub-e2e/src/e2e/dataset/datasetDetailPage.cy.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/datahub-e2e/src/e2e/dataset/datasetDetailPage.cy.ts b/apps/datahub-e2e/src/e2e/dataset/datasetDetailPage.cy.ts index b7aa32ffec..dc7eb18d44 100644 --- a/apps/datahub-e2e/src/e2e/dataset/datasetDetailPage.cy.ts +++ b/apps/datahub-e2e/src/e2e/dataset/datasetDetailPage.cy.ts @@ -119,9 +119,10 @@ describe('Sections', () => { cy.get('datahub-record-metadata') .find('[id="about"]') .find('gn-ui-max-lines') + .first() .as('maxLines') cy.get('@maxLines').find('.ease-out').should('exist') - cy.get('[data-cy=readMoreButton]').click() + cy.get('[data-cy=readMoreButton]').first().click() cy.get('@maxLines').find('.ease-in').should('exist') cy.go('back')