Skip to content

Commit 7e3e174

Browse files
removing some async part
1 parent 593a531 commit 7e3e174

File tree

6 files changed

+234
-151
lines changed

6 files changed

+234
-151
lines changed

etpproto/connection.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from dataclasses import dataclass, field
88
from enum import Enum
99
from typing import (
10+
Generator,
1011
AsyncGenerator,
1112
Callable,
1213
ClassVar,
@@ -55,12 +56,12 @@
5556

5657

5758
class Protocol:
58-
async def handle_message(
59+
def handle_message(
5960
self,
6061
etp_object: object,
6162
msg_header: MessageHeader,
6263
client_info: Union[None, ClientInfo] = None,
63-
) -> AsyncGenerator[Optional[Message], None]:
64+
) -> Generator[Optional[Message], None]:
6465
yield NotSupportedError().to_etp_message(
6566
correlation_id=msg_header.message_id
6667
)
@@ -385,9 +386,9 @@ async def _handle_message_generator(
385386
msg_id=self.consume_msg_id()
386387
)
387388

388-
async def send_msg_and_error_generator(
389+
def send_msg_and_error_generator(
389390
self, msg: Message, err_msg: Message
390-
) -> AsyncGenerator[Tuple[int, bytes], None]:
391+
) -> Generator[Tuple[int, bytes], None]:
391392
current_msg_id = self.consume_msg_id()
392393

393394
if msg:
@@ -398,7 +399,7 @@ async def send_msg_and_error_generator(
398399
# err_msg.header.message_id = self.message_id
399400
# self.message_id += 2
400401

401-
async for msg_part in msg.encode_message_generator(
402+
for msg_part in msg.encode_message_generator(
402403
self.client_info.getCapability(
403404
"MaxWebSocketMessagePayloadSize"
404405
),
@@ -407,7 +408,7 @@ async def send_msg_and_error_generator(
407408
yield (current_msg_id, msg_part)
408409

409410
if err_msg:
410-
async for msg_part in err_msg.encode_message_generator(
411+
for msg_part in err_msg.encode_message_generator(
411412
self.client_info.getCapability(
412413
"MaxWebSocketMessagePayloadSize"
413414
),
@@ -417,7 +418,7 @@ async def send_msg_and_error_generator(
417418

418419
elif err_msg:
419420
# logging.debug(f"{self.client_info.ip} : Encoding error")
420-
async for msg_part in err_msg.encode_message_generator(
421+
for msg_part in err_msg.encode_message_generator(
421422
self.client_info.getCapability(
422423
"MaxWebSocketMessagePayloadSize"
423424
),
@@ -439,7 +440,7 @@ async def handle_bytes_generator(
439440

440441
async for msg in self._handle_message_generator(etp_input_msg):
441442
if msg is not None:
442-
async for msg_part in msg.encode_message_generator(
443+
for msg_part in msg.encode_message_generator(
443444
self.client_info.getCapability(
444445
"MaxWebSocketMessagePayloadSize"
445446
),

etpproto/messages.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from enum import IntFlag
1414
from io import BytesIO
1515
from math import ceil
16-
from typing import AsyncGenerator, Dict, List, Optional, Tuple, Any, Union
16+
from typing import Generator, Dict, List, Optional, Tuple, Any, Union
1717

1818
import etptypes.energistics.etp.v12.datatypes.message_header as mh
1919
from etptypes import ETPModel, avro_schema
@@ -90,9 +90,9 @@ def encode_message(self) -> bytes:
9090
# - Sinon, on si contient un BLOB, on essaie de le couper en plusieurs messages
9191
# - Sinon on envoie un message d'erreur
9292
# max_bytes_per_msg : negative number for infinite size
93-
async def encode_message_generator( # noqa
93+
def encode_message_generator( # noqa
9494
self, max_bytes_per_msg, connection
95-
) -> AsyncGenerator[bytes, None]:
95+
) -> Generator[bytes, None]:
9696
# si requete on met le correlation_id sur le l'id du premier message
9797
# si self a un correlation_id alors c'est que ce n'était pas le premier
9898
correlation_id = (
@@ -181,11 +181,11 @@ async def encode_message_generator( # noqa
181181
msg2.add_header_flag(MessageFlags.MULTIPART)
182182

183183
msg1.set_final_msg(False)
184-
async for part in msg1.encode_message_generator(
184+
for part in msg1.encode_message_generator(
185185
max_bytes_per_msg, connection
186186
):
187187
yield part
188-
async for part in msg2.encode_message_generator(
188+
for part in msg2.encode_message_generator(
189189
max_bytes_per_msg, connection
190190
):
191191
yield part
@@ -195,7 +195,7 @@ async def encode_message_generator( # noqa
195195
and len(values) > 0
196196
and self.is_chunkable()
197197
):
198-
async for part in _encode_message_generator_chunk(
198+
for part in _encode_message_generator_chunk(
199199
chunkable_msg=self,
200200
encoded_msg_size=body_size,
201201
max_bytes_per_msg=max_bytes_per_msg,
@@ -220,7 +220,7 @@ async def encode_message_generator( # noqa
220220
)
221221
if msg_err is not None:
222222
msg_err.set_final_msg(True)
223-
async for part in msg_err.encode_message_generator(
223+
for part in msg_err.encode_message_generator(
224224
-1, connection
225225
):
226226
yield part
@@ -491,12 +491,12 @@ def decode_binary_message(
491491

492492

493493
# When calling thins function we are supposed to have only one entry in the data_objects map/list
494-
async def _encode_message_generator_chunk(
494+
def _encode_message_generator_chunk(
495495
chunkable_msg: Message,
496496
encoded_msg_size: int,
497497
max_bytes_per_msg: int,
498498
connection,
499-
) -> AsyncGenerator[bytes, None]:
499+
) -> Generator[bytes, None]:
500500
from etpproto.error import InternalError
501501

502502
secure_size = 50 # TODO : ameliorer pour que le chunk fasse vraiment la taille max d'un message (il faudrait connaitre la taille de ce qui n'est pas binaire dans le chunk message)
@@ -585,7 +585,7 @@ async def _encode_message_generator_chunk(
585585
# send the message
586586
chunkable_msg.set_final_msg(False)
587587
chunkable_msg.add_header_flag(MessageFlags.MULTIPART)
588-
async for part in chunkable_msg.encode_message_generator(
588+
for part in chunkable_msg.encode_message_generator(
589589
max_bytes_per_msg, connection
590590
):
591591
yield part
@@ -600,7 +600,7 @@ async def _encode_message_generator_chunk(
600600
message_flags=MessageFlags.MULTIPART,
601601
)
602602
if current_chunk_msg is not None:
603-
async for (
603+
for (
604604
part
605605
) in current_chunk_msg.encode_message_generator(
606606
max_bytes_per_msg, connection
@@ -625,7 +625,7 @@ async def _encode_message_generator_chunk(
625625
),
626626
)
627627
if final_chunk_msg is not None:
628-
async for part in final_chunk_msg.encode_message_generator(
628+
for part in final_chunk_msg.encode_message_generator(
629629
max_bytes_per_msg, connection
630630
):
631631
yield part

etpproto/protocols/__init__.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,19 @@
11
# Copyright (c) 2022-2023 Geosiris.
22
# SPDX-License-Identifier: Apache-2.0
3+
4+
from .channel_data_frame import ChannelDataFrameHandler
5+
from .channel_data_load import ChannelDataLoadHandler
6+
from .channel_streaming import ChannelStreamingHandler
7+
from .channel_subscribe import ChannelSubscribeHandler
8+
from .core import CoreHandler
9+
from .data_array import DataArrayHandler
10+
from .dataspace import DataspaceHandler
11+
from .discovery import DiscoveryHandler
12+
from .growing_object import GrowingObjectHandler
13+
from .growing_object_query import GrowingObjectQueryHandler
14+
from .growing_object_notification import GrowingObjectNotificationHandler
15+
from .store_notification import StoreNotificationHandler
16+
from .store_query import StoreQueryHandler
17+
from .store import StoreHandler
18+
from .supported_types import SupportedTypesHandler
19+
from .transaction import TransactionHandler

0 commit comments

Comments
 (0)