Error notification with version 0.2.0

[sschulz92]

Recently, there was a new VS Code plugin version released. Since this version, I can see an error notification whenever the Gauge plugin starts.

In src/cli.ts the private method was changed (hash efa4711a91c3133162c4b3fd2bc65c565b655e2c) to actually show this:

private static getCommand(command: string): string {
    for (const candidate of this.getCommandCandidates(command)) {
        if (this.checkSpawnable(candidate)) return candidate;
    }
    window.showErrorMessage(`Unable to find executable launch command: ${command}`);
}

Question: Why is the error shown now? How can I overcome this error notification?

Side note: In my PATH you can find the command "mvn", though VS Code plugin Gauge does not recognize it.

[chadlwilson]

Yeah, I think I'll remove it.

It's an unintentional consequence of trying to give feedback when launching of gauge fails, where the same code is used for both maven support (apparently eagerly invoked rather than only when used) and the core gauge support.

But I suspect mvn is not actually on the path visible to vscode in your case. Are you sure? Which OS?

[chadlwilson]

If you follow the commit to the PR referenced you'll be able to see the motivation via #1052 and #1049

[sschulz92]

If I am running mvn -v in my Git bash, I can see the following:

$ mvn -v
Apache Maven 3.9.2 (c9616018c7a021c1c39be70fb2843d6f5f9b8a1c)
Maven home: C:\maven\apache-maven-3.9.2
Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Java\jdk-17.0.8+7
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

On another note, I tried to work around the error notification by setting the executable path in VS Code too. So in my settings.json I can see the following: "maven.executable.path": "C:\\maven\\apache-maven-3.9.2\\bin"
This should be enough for VS Code to see mvn too, right?

[chadlwilson]

Well path for git bash can be different to system path; and it also brings in *nix semantics for executable scripts since it is an actual shell. The VSCode plugin doesn't fork/spawn processes into a git bash shell, it needs .exe, .bat, .cmd somewhere on the path.

It also doesn't seem to be that maven.executable.path is directly used by the plugin, but I don't know how VS code sets its own or propagates paths as I don't use it enough to have dug deeper (and certainly not on Windows).

[chadlwilson]

Try 0.2.1. Sorry for the hassle.

Serves me right for trying to incorporate too many ideas from competing PRs and getting it wrong due to haste.

If you think your experience points to something wider wrong with the mvn command location logic and you're confident it's on your system or user path as visible by VSCode I'm happy to debug that separately, since the main point of the fixes in 0.2.0 was to address issues with launching mvn.bat/mvn.cmd on Windows with newer VSCode versions. (per #1045)