Skip to content

Commit a201338

Browse files
committed
qrpred not fully defined in GLM v1.9
1 parent 9e1d6ec commit a201338

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/linpred.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,12 +180,13 @@ leverage_weights(p::LinPred, wt::AbstractVector) = sqrt.(1 .- leverage(p, wt))
180180
## Use DensePredQR from GLM
181181
elseif get_pkg_version(GLM) < v"1.10"
182182
using GLM: DensePredQR
183-
qrpred(X::AbstractMatrix, pivot::Bool=false) = DensePredQR(X, pivot)
183+
# GLM.DensePredQR(X::AbstractMatrix, pivot::Bool) is not defined
184+
qrpred(X::AbstractMatrix, pivot::Bool=false) = DensePredQR(X)
184185

185186
else
186187
using GLM: DensePredQR
188+
# GLM.DensePredQR(X::AbstractMatrix, pivot::Bool) is defined in #master
187189
import GLM: qrpred
188-
189190
end
190191

191192

0 commit comments

Comments
 (0)