Skip to content

Commit 56d418f

Browse files
kpreidcwfitzgerald
authored andcommitted
Partial revert "disable rustdoc in CI (#5839)"
This reverts most of the changes in a2fcd72, but the "document private features" step is still disabled since it operates only on wgpu-core which is exactly the problem.
1 parent b5934e8 commit 56d418f

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,10 @@ jobs:
150150
cargo -V
151151
152152
# Use special toolchain for rustdoc, see https://github.com/gfx-rs/wgpu/issues/4905
153-
# - name: Install Rustdoc Toolchain
154-
# run: |
155-
# rustup toolchain install ${{ env.DOCS_RUST_VERSION }} --no-self-update --profile=minimal --component rust-docs --target ${{ matrix.target }}
156-
# cargo +${{ env.DOCS_RUST_VERSION }} -V
153+
- name: Install Rustdoc Toolchain
154+
run: |
155+
rustup toolchain install ${{ env.DOCS_RUST_VERSION }} --no-self-update --profile=minimal --component rust-docs --target ${{ matrix.target }}
156+
cargo +${{ env.DOCS_RUST_VERSION }} -V
157157
158158
- name: disable debug
159159
shell: bash
@@ -195,11 +195,11 @@ jobs:
195195
# build for WebGPU
196196
cargo clippy --target ${{ matrix.target }} --tests --features glsl,spirv,fragile-send-sync-non-atomic-wasm
197197
cargo clippy --target ${{ matrix.target }} --tests --features glsl,spirv
198-
# cargo +${{ env.DOCS_RUST_VERSION }} doc --target ${{ matrix.target }} --no-deps --features glsl,spirv
198+
cargo +${{ env.DOCS_RUST_VERSION }} doc --target ${{ matrix.target }} --no-deps --features glsl,spirv
199199
200200
# all features
201201
cargo clippy --target ${{ matrix.target }} --tests --all-features
202-
# cargo +${{ env.DOCS_RUST_VERSION }} doc --target ${{ matrix.target }} --no-deps --all-features
202+
cargo +${{ env.DOCS_RUST_VERSION }} doc --target ${{ matrix.target }} --no-deps --all-features
203203
204204
- name: check em
205205
if: matrix.kind == 'em'
@@ -229,13 +229,15 @@ jobs:
229229
cargo clippy --target ${{ matrix.target }} --tests --benches --all-features
230230
231231
# build docs
232-
# cargo +${{ env.DOCS_RUST_VERSION }} doc --target ${{ matrix.target }} --all-features --no-deps
232+
cargo +${{ env.DOCS_RUST_VERSION }} doc --target ${{ matrix.target }} --all-features --no-deps
233+
# wgpu-core docs are not feasible due to <https://github.com/gfx-rs/wgpu/issues/4905>
234+
#
233235
# - name: check private item docs
234236
# if: matrix.kind == 'native'
235237
# shell: bash
236238
# run: |
237239
# set -e
238-
240+
#
239241
# # wgpu_core package
240242
# cargo +${{ env.DOCS_RUST_VERSION }} doc --target ${{ matrix.target }} \
241243
# --package wgpu-core \

0 commit comments

Comments
 (0)