ensure index is not overwritten (#3754)

* fix apply

* fix index

* make it foolproof

* fix

Author: thelostone-mc

packages/builder/src/utils/roundApplication.ts

@@ -56,8 +56,6 @@ export const parseRoundApplicationMetadata = (
     };
   }
 
-  // const [major, minor, patch] = object.version.split(".").map(Number);
-  //
   metadata.applicationSchema.questions =
     metadata.applicationSchema.questions.map(
       (q: any): RoundApplicationQuestion => ({
@@ -71,13 +69,17 @@ export const parseRoundApplicationMetadata = (
       })
     );
 
+  const maxId = Math.max(
+    ...metadata.applicationSchema.questions.map((q) => q.id)
+  );
+
   metadata.applicationSchema.questions = [
     {
-      id: metadata.applicationSchema.questions.length,
+      id: maxId + 1,
       type: "project",
     },
     {
-      id: metadata.applicationSchema.questions.length + 1,
+      id: maxId + 2,
       type: "recipient",
     },
     ...metadata.applicationSchema.questions,

packages/common/.env.test

@@ -1,5 +1,4 @@
 REACT_APP_GRANTS_STACK_SEARCH_API_BASE_URL="https://gitcoin-search-dev.fly.dev"
-REACT_APP_ALLO_API_URL="https://grants-stack-indexer-v2.gitcoin.co/graphql"
 REACT_APP_PINATA_JWT=token-test
 REACT_APP_PINATA_BASE_URL=http://localhost
 REACT_APP_PASSPORT_API_KEY="test-key"