Skip to content

Commit 312e524

Browse files
authored
Merge pull request #107 from deeglaze/footgun
Add a warning about default product use
2 parents b0523ea + 607a6cf commit 312e524

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

verify/verify.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828
cpb "github.com/google/go-sev-guest/proto/check"
2929
spb "github.com/google/go-sev-guest/proto/sevsnp"
3030
"github.com/google/go-sev-guest/verify/trust"
31+
"github.com/google/logger"
3132
"github.com/pborman/uuid"
3233
"github.com/pkg/errors"
3334
"go.uber.org/multierr"
@@ -684,6 +685,7 @@ func fillInAttestation(attestation *spb.Attestation, options *Options) error {
684685
if options.Product != nil {
685686
attestation.Product = options.Product
686687
} else {
688+
logger.Warning("Attestation missing product information. KDS certificate may be invalid. Using default Milan-B1")
687689
attestation.Product = abi.DefaultSevProduct()
688690
}
689691
productOverridden = true

0 commit comments

Comments
 (0)