Removed borrow_parts for Address in favour of From impl.

Author: horned-sphere

server/swimos_connector_kafka/src/config/egress.rs

@@ -95,9 +95,9 @@ impl From<&DownlinkAddress> for Address<String> {
     }
 }
 
-impl DownlinkAddress {
-    pub fn borrow_as_addr(&self) -> Address<&str> {
-        let DownlinkAddress { host, node, lane } = self;
+impl<'a> From<&'a DownlinkAddress> for Address<&'a str> {
+    fn from(value: &'a DownlinkAddress) -> Self {
+        let DownlinkAddress { host, node, lane } = value;
         Address {
             host: host.as_ref().map(|s| s.as_str()),
             node,

server/swimos_connector_kafka/src/connector/egress/mod.rs

@@ -254,10 +254,10 @@ fn open_downlinks(config: &KafkaEgressConfiguration, context: &mut dyn EgressCon
         ..
     } = config;
     for value_dl in value_downlinks {
-        context.open_event_downlink(value_dl.address.borrow_as_addr());
+        context.open_event_downlink(<Address<&str>>::from(&value_dl.address));
     }
     for map_dl in map_downlinks {
-        context.open_map_downlink(map_dl.address.borrow_as_addr());
+        context.open_map_downlink(<Address<&str>>::from(&map_dl.address));
     }
 }
 

server/swimos_connector_kafka/src/connector/egress/tests/integration.rs

@@ -277,8 +277,8 @@ fn initialize_connector() {
     .into_iter()
     .collect::<HashMap<_, _>>();
 
-    assert_eq!(value_downlinks, vec![Address::from(&addr1())]);
-    assert_eq!(map_downlinks, vec![Address::from(&addr2())]);
+    assert_eq!(value_downlinks, vec![Address::<String>::from(&addr1())]);
+    assert_eq!(map_downlinks, vec![Address::<String>::from(&addr2())]);
     assert_eq!(lanes_map, expected_lanes);
 }