fix: Continue upon ENOSUP chmod failures (#19)

Author: phated

mkdirp.js

@@ -93,7 +93,15 @@ function mkdirp(dirpath, mode, callback) {
         return callback();
       }
 
-      fs.chmod(dirpath, mode, callback);
+      fs.chmod(dirpath, mode, onChmod);
+    }
+
+    function onChmod(chmodErr) {
+      if (chmodErr && chmodErr.code !== 'ENOSUP') {
+        return callback(chmodErr);
+      }
+
+      callback();
     }
 
     function onNonDirectory(err, dirpath, stats) {

test/mkdirp.js

@@ -272,6 +272,40 @@ function suite() {
     });
   });
 
+  it('surfaces chmod errors', function (done) {
+    sinon.stub(fs, 'chmod').callsFake(function (p, mode, cb) {
+      cb(new Error('boom'));
+    });
+
+    var mode = '777';
+
+    mkdirp(outputDirpath, mode, function (err) {
+      fs.chmod.restore();
+
+      expect(err).toBeDefined();
+
+      done();
+    });
+  });
+
+  it('does not surface error ENOSUP if chmod is unsupported on the path', function (done) {
+    sinon.stub(fs, 'chmod').callsFake(function (p, mode, cb) {
+      var err = new Error('boom');
+      err.code = 'ENOSUP';
+      cb(err);
+    });
+
+    var mode = '777';
+
+    mkdirp(outputDirpath, mode, function (err) {
+      fs.chmod.restore();
+
+      expect(err).not.toBeDefined();
+
+      done();
+    });
+  });
+
   it('errors with ENOTDIR if file in path', function (done) {
     fs.mkdir(outputDirpath, function (err) {
       expect(err).toBeFalsy();