Skip to content

Commit a0bfd1f

Browse files
committed
node-addon-api@8.5
node-addon-api@8.5 introduces Napi::Promise::Then.
1 parent eb4ab3a commit a0bfd1f

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

package-lock.json

Lines changed: 8 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"packageManager": "npm@8.19.2",
2+
"packageManager": "npm@11.5.1",
33
"name": "@hanazuki/node-jsonnet",
44
"version": "3.0.0",
55
"description": "Jsonnet addon for Node.js",
@@ -79,7 +79,7 @@
7979
"dependencies": {
8080
"bindings": "^1.5.0",
8181
"cmake-js": "^7.3.0",
82-
"node-addon-api": "^8.0.0"
82+
"node-addon-api": "^8.5.0"
8383
},
8484
"devDependencies": {
8585
"@definitelytyped/dtslint": "^0.0.182",

src/JsonnetNativeCallback.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,7 @@ namespace nodejsonnet {
5656
},
5757
"onFailure", payload);
5858

59-
auto const promise = result.As<Napi::Object>();
60-
promise.Get("then").As<Napi::Function>().Call(promise, {on_success, on_failure});
59+
result.As<Napi::Promise>().Then(on_success, on_failure);
6160
}
6261

6362
}

0 commit comments

Comments
 (0)