Make validating host[:port] more elegant

Greg Dubicki · Greg Dubicki · commit 2c7e3dd6cb7e · 2020-05-28T17:31:51.000+02:00
diff --git a/main.go b/main.go
@@ -71,7 +71,7 @@ func validateLogAddress(logAddress string) error {
 		if err != nil && match {
 			return nil
 		}
-		if !govalidator.IsDialString(logAddress) && !govalidator.IsDialString(logAddress+":514") {
+		if !govalidator.IsHost(logAddress) && !govalidator.IsDialString(logAddress) {
 			return errors.New(fmt.Sprintf("%s should be either syslog host[:port] or a socket", logAddress))
 		}
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ func validateLogAddress(logAddress string) error {`
`71`	`71`	`if err != nil && match {`
`72`	`72`	`return nil`
`73`	`73`	`}`
`74`		`- if !govalidator.IsDialString(logAddress) && !govalidator.IsDialString(logAddress+":514") {`
	`74`	`+ if !govalidator.IsHost(logAddress) && !govalidator.IsDialString(logAddress) {`
`75`	`75`	`return errors.New(fmt.Sprintf("%s should be either syslog host[:port] or a socket", logAddress))`
`76`	`76`	`}`
`77`	`77`	`} else {`