Skip to content

README documentation incorrect line 169 logit_dim #98

@tynanseltzer

Description

@tynanseltzer

On line 169 of README, dist = ntorch.distributions.Categorical(logits=params, logit_dim="logits") is incorrect, in that the keyword is dim_logitas seen on line 27 of namedtensor/distributions/distributions.py. While a simple fix would be changing the README, I actually prefer logit_dim over dim_logit so would prefer changing the keyword. This, however, has issues with backwards compatibility.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions