Activate more warnings, including Wunused-packages for GHC 8.10+

Author: LaurentRDC

beam-core/beam-core.cabal

@@ -84,8 +84,13 @@ library
                        DefaultSignatures, KindSignatures, MultiParamTypeClasses, DeriveGeneric, DeriveFunctor, DeriveDataTypeable,
                        TypeApplications, FunctionalDependencies, DataKinds, BangPatterns, InstanceSigs
   ghc-options:         -Wall
+                       -Widentities
+                       -Wincomplete-uni-patterns
+                       -Wincomplete-record-updates
   if impl(ghc >= 8.8)
     ghc-options: -Wcompat
+  if impl(ghc >= 8.10)
+    ghc-options: -Wunused-packages
   if flag(werror)
     ghc-options:       -Werror
   if impl(ghc >= 8.10)

beam-migrate/ChangeLog.md

@@ -1,3 +1,9 @@
+# Unreleased
+
+## Dependencies
+
+* Removed explicit dependency on `ghc-prim`, which was not used directly.
+
 # 0.5.3.1
 
 ## Bug fixes
@@ -18,7 +24,7 @@
 
 # 0.5.2.0
 
-## Addded features
+## Added features
 
  * `IN (SELECT ...)` syntax via `inSelectE`
 

beam-migrate/Database/Beam/Migrate/Actions.hs

@@ -440,7 +440,7 @@ addColumnProvider =
          pure (PotentialAction mempty (HS.fromList ([SomeDatabasePredicate colP] ++ constraintsP))
                                (Seq.singleton (MigrationCommand cmd MigrationKeepsData))
                                ("Add column " <> colNm <> " to " <> qnameAsText tblNm)
-                (addColumnWeight + fromIntegral (T.length (qnameAsText tblNm) + T.length colNm)))
+                (addColumnWeight + (T.length (qnameAsText tblNm) + T.length colNm)))
 
 -- | Action provider for SQL92 @ALTER TABLE ... DROP COLUMN ...@ actions
 dropColumnProvider :: forall be
@@ -469,7 +469,7 @@ dropColumnProvider = ActionProvider provider
          pure (PotentialAction (HS.fromList (SomeDatabasePredicate colP:relatedPreds)) mempty
                                (Seq.singleton (MigrationCommand cmd MigrationLosesData))
                                ("Drop column " <> colNm <> " from " <> qnameAsText tblNm)
-                (dropColumnWeight + fromIntegral (T.length (qnameAsText tblNm) + T.length colNm)))
+                (dropColumnWeight + (T.length (qnameAsText tblNm) + T.length colNm)))
 
 -- | Action provider for SQL92 @ALTER TABLE ... ALTER COLUMN ... SET NULL@
 addColumnNullProvider :: forall be

beam-migrate/beam-migrate.cabal

@@ -69,7 +69,6 @@ library
                        microlens            >=0.4     && <0.5,
                        parallel             >=3.2     && <3.3,
                        deepseq              >=1.4     && <1.7,
-                       ghc-prim             >=0.5     && <0.14,
                        haskell-src-exts     >=1.18    && <1.24,
                        pretty               >=1.1     && <1.2,
                        dependent-map        >=0.2     && <0.5,
@@ -82,8 +81,13 @@ library
                        FlexibleInstances, TypeOperators, TypeApplications, MultiParamTypeClasses,
                        DataKinds, DeriveGeneric
   ghc-options:         -Wall
+                       -Widentities
+                       -Wincomplete-uni-patterns
+                       -Wincomplete-record-updates
   if flag(werror)
     ghc-options:       -Werror
+  if impl(ghc >= 8.10)
+    ghc-options: -Wunused-packages
 
 flag werror
   description: Enable -Werror during development

beam-postgres/beam-postgres.cabal

@@ -66,6 +66,11 @@ library
                       DeriveDataTypeable, DeriveGeneric, StandaloneDeriving, TypeFamilies, GADTs, OverloadedStrings,
                       CPP, TypeApplications, FlexibleContexts
   ghc-options:        -Wall
+                      -Widentities
+                      -Wincomplete-uni-patterns
+                      -Wincomplete-record-updates
+  if impl(ghc >= 8.10)
+    ghc-options: -Wunused-packages
   if flag(werror)
     ghc-options: -Werror
 

beam-sqlite/Database/Beam/Sqlite/Syntax.hs

@@ -710,7 +710,7 @@ instance HasSqlValueSyntax SqliteValueSyntax Int16 where
 instance HasSqlValueSyntax SqliteValueSyntax Int32 where
   sqlValueSyntax i = SqliteValueSyntax (emitValue (SQLInteger (fromIntegral i)))
 instance HasSqlValueSyntax SqliteValueSyntax Int64 where
-  sqlValueSyntax i = SqliteValueSyntax (emitValue (SQLInteger (fromIntegral i)))
+  sqlValueSyntax i = SqliteValueSyntax (emitValue (SQLInteger i))
 instance HasSqlValueSyntax SqliteValueSyntax Word8 where
   sqlValueSyntax i = SqliteValueSyntax (emitValue (SQLInteger (fromIntegral i)))
 instance HasSqlValueSyntax SqliteValueSyntax Word16 where

beam-sqlite/beam-sqlite.cabal

@@ -47,8 +47,13 @@ library
                       DeriveDataTypeable, DeriveGeneric, StandaloneDeriving, TypeFamilies, GADTs, OverloadedStrings,
                       CPP, TypeApplications, FlexibleContexts, ConstraintKinds, DerivingStrategies
   ghc-options:        -Wall
+                      -Widentities
+                      -Wincomplete-uni-patterns
+                      -Wincomplete-record-updates
+  if impl(ghc >= 8.10)
+    ghc-options: -Wunused-packages
   if flag(werror)
-    ghc-options:       -Werror
+    ghc-options: -Werror
 
 test-suite beam-sqlite-tests
   type: exitcode-stdio-1.0