Fixed letter repetition bug #20

Author: havardt

source/EzPasswordValidator.Tests/LetterRepetitionCheckTest.cs

@@ -29,7 +29,12 @@ public void WhenPasswordContainsTheSameLetterThreeTimesInARowThenPasswordIsValid
             Assert.IsTrue(_check.Execute(psw));
 
         /// <summary> This test assumes that the default repetition length is 4. </summary>
+        [DataRow("Aaaa@2022")]
+        [DataRow("aaaA@2022")]
         [DataRow("testAAAA")]
+        [DataRow("testAaaa")]
+        [DataRow("testaaaA")]
+        [DataRow("aAaatest")]
         [DataRow("teAAAAAst")]
         [DataRow("AAAAtesBBBt")]
         [DataRow("ØØØØtest")] //Non ISO basic latin test case

source/EzPasswordValidator/Checks/CheckHelper.cs

@@ -49,7 +49,7 @@ public static bool RepetitionCheck(Func<char, bool> expr, string str)
 
         /// <summary>
         ///   Checks if the given string contains character repetition of the
-        ///   given length or longer.
+        ///   given length or longer (NOT case sensitive).
         /// </summary>
         /// <param name="expr">The expression of which filters which characters to check for repetition.</param>
         /// <param name="str">The string to check.</param>
@@ -62,13 +62,14 @@ public static bool RepetitionCheck(Func<char, bool> expr, string str)
         public static bool RepetitionCheck(Func<char, bool> expr, string str, int len)
         {
             int count = 1; // The current amount of repetitions.
-            int previousChar = 0;
+            int previousChar = char.ToLower(str[0]);
 
-            foreach (char c in str)
+            foreach (char c in str.Substring(1))
             {
                 if (expr.Invoke(c))
                 {
-                    if (previousChar == c)
+                    char currentChar = char.ToLower(c);
+                    if (previousChar == currentChar)
                     {
                         count++;
                         if (count == len)
@@ -78,7 +79,7 @@ public static bool RepetitionCheck(Func<char, bool> expr, string str, int len)
                     }
                     else
                     {
-                        previousChar = c;
+                        previousChar = currentChar;
                         count = 1;
                     }
                 }

source/EzPasswordValidator/EzPasswordValidator.csproj

@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
-    <PackageLicenseUrl>https://mit-license.org/</PackageLicenseUrl>
     <Authors>havardt</Authors>
     <Company />
     <PackageId>EzPasswordValidator</PackageId>
@@ -12,19 +11,18 @@
     <RepositoryType>git</RepositoryType>
     <PackageTags>Password Validator Library Checker EzPasswordValidator csharp password-validation easy</PackageTags>
     <SignAssembly>true</SignAssembly>
-    <Version>2.0.0</Version>
-    <AssemblyVersion>2.0.0.0</AssemblyVersion>
-    <FileVersion>2.0.0.0</FileVersion>
+    <Version>2.1.0</Version>
+    <AssemblyVersion>2.1.0.0</AssemblyVersion>
+    <FileVersion>2.1.0.0</FileVersion>
     <AssemblyOriginatorKeyFile>ezpasswordvalidator_sign_key.pfx</AssemblyOriginatorKeyFile>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
-    <PackageReleaseNotes>**IMPORTANT** v2.0.0 is a major version change and brings some breaking changes. 
+    <PackageReleaseNotes>New in version 2.1.0:
+- Fixed bug in letter repetition check. The check is now case-sensitive.
 
-New in this version:
-- Partial criteria matching
-- User can customize length on sequences and repetition checks
-- Default requirements have been updated (See docs)
-- Replaced some slow regex</PackageReleaseNotes>
-    <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
+**IMPORTANT** Upgrading from version 1.x? Version 2.x is a major version change and brings some breaking changes. 
+</PackageReleaseNotes>
+    <PackageRequireLicenseAcceptance>False</PackageRequireLicenseAcceptance>
+    <PackageLicenseExpression>MIT</PackageLicenseExpression>
   </PropertyGroup>
 
 </Project>