From c087efeb929c276cd11cb3578b5c84fe41f64122 Mon Sep 17 00:00:00 2001 From: Jack Green Date: Fri, 13 Jun 2025 10:47:00 +0100 Subject: [PATCH] Fix `codecov-action` [DI-520] The C++ coverage action has been [silently failing](https://github.com/hazelcast/hazelcast-cpp-client/actions/runs/15610247637/attempts/1). Updated all usages to: - supply a token to properly authenticate (the reason for the failure) - fail the step if the upload fails (to avoid the error going unreported) - use the latest version (consistency) Fixes: [DI-520](https://hazelcast.atlassian.net/browse/DI-520) --- .github/workflows/coverage_runner.yml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/coverage_runner.yml b/.github/workflows/coverage_runner.yml index 86d90dded8..e3cc0609e2 100644 --- a/.github/workflows/coverage_runner.yml +++ b/.github/workflows/coverage_runner.yml @@ -87,23 +87,29 @@ jobs: - name: Publish results to Codecov for PR coming from hazelcast organization if: ${{ matrix.python-version == needs.python-versions.outputs.latest-python-version && matrix.os == 'ubuntu-latest' && github.event_name == 'pull_request_target' }} - uses: codecov/codecov-action@v1 + uses: codecov/codecov-action@v5 with: + token: ${{ secrets.CODECOV_TOKEN }} files: ./coverage.xml override_pr: ${{ github.event.pull_request.number }} + fail_ci_if_error: true - name: Publish results to Codecov for Push if: ${{ matrix.python-version == needs.python-versions.outputs.latest-python-version && matrix.os == 'ubuntu-latest' && github.event_name == 'push' }} - uses: codecov/codecov-action@v1 + uses: codecov/codecov-action@v5 with: + token: ${{ secrets.CODECOV_TOKEN }} files: ./coverage.xml + fail_ci_if_error: true - name: Publish result to Codecov for PR coming from community if: ${{ matrix.python-version == needs.python-versions.outputs.latest-python-version && matrix.os == 'ubuntu-latest' && github.event_name == 'workflow_dispatch' }} - uses: codecov/codecov-action@v1 + uses: codecov/codecov-action@v5 with: + token: ${{ secrets.CODECOV_TOKEN }} files: ./coverage.xml override_pr: ${{ github.event.inputs.pr_number }} + fail_ci_if_error: true - name: Upload remote controller logs if test run fails uses: actions/upload-artifact@v4