Skip to content

Commit ad01194

Browse files
committed
Linting fix
1 parent 7eb8e4d commit ad01194

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

server/runtime_javascript_test.go

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -117,29 +117,36 @@ const data = `{"title_data":{"ads_config": [1,2,3]}}`
117117

118118
// go test -run=XXX -bench=BenchmarkParse ./...
119119
// go test -run=XXX -bench=BenchmarkParse ./... -benchmem
120-
func BenchmarkParseJsonGo(b *testing.B) {
120+
func BenchmarkParseJsonGoja(b *testing.B) {
121121
vm := goja.New()
122122
b.ResetTimer()
123123
for i := 0; i < b.N; i++ {
124124
v, err := jsJsonParse(vm, data)
125125
if err != nil {
126126
b.Fatal(err)
127127
}
128-
vm.Set("data", v)
129-
vm.RunString(`data.foo = []; data.foo.push(3)`)
128+
_ = vm.Set("data", v)
129+
_, err = vm.RunString(`data.foo = []; data.foo.push(3)`)
130+
if err != nil {
131+
b.Fatal(err)
132+
}
130133
}
131134
}
132-
func BenchmarkParseJsonGoja(b *testing.B) {
135+
func BenchmarkParseJsonGo(b *testing.B) {
133136
vm := goja.New()
134137
b.ResetTimer()
135138
for i := 0; i < b.N; i++ {
136139
var out map[string]any
137-
if err := json.Unmarshal([]byte(data), &out); err != nil {
140+
err := json.Unmarshal([]byte(data), &out)
141+
if err != nil {
138142
b.Fatal(err)
139143
}
140144
pointerizeSlices(out)
141-
vm.Set("data", out)
142-
vm.RunString(`data.foo = []; data.foo.push(3)`)
145+
_ = vm.Set("data", out)
146+
_, err = vm.RunString(`data.foo = []; data.foo.push(3)`)
147+
if err != nil {
148+
b.Fatal(err)
149+
}
143150
}
144151
}
145152

0 commit comments

Comments
 (0)