Merge pull request #621 from fingolfin/mh/InstallValue

mohamed-barakat · web-flow · commit 774f5aa2f069 · 2024-12-21T23:39:31.000+01:00
Avoid using InstallValue on non-plain objects
diff --git a/GradedModules/gap/Tate.gd b/GradedModules/gap/Tate.gd
@@ -16,14 +16,10 @@ DeclareGlobalFunction( "_Functor_TateResolution_OnGradedModules" );
 
 DeclareGlobalFunction( "_Functor_TateResolution_OnGradedMaps" );
 
-DeclareGlobalVariable( "Functor_TateResolution_ForGradedModules" );
-
 DeclareGlobalFunction( "_Functor_LinearStrandOfTateResolution_OnGradedModules" );
 
 DeclareGlobalFunction( "_Functor_LinearStrandOfTateResolution_OnGradedMaps" );
 
-DeclareGlobalVariable( "Functor_LinearStrandOfTateResolution_ForGradedModules" );
-
 
 # basic operations:
 
diff --git a/GradedModules/gap/Tate.gi b/GradedModules/gap/Tate.gi
@@ -440,7 +440,7 @@ InstallGlobalFunction( _Functor_TateResolution_OnGradedMaps, ### defines: TateRe
     
 end );
 
-InstallValue( Functor_TateResolution_ForGradedModules,
+BindGlobal( "Functor_TateResolution_ForGradedModules",
         CreateHomalgFunctor(
                 [ "name", "TateResolution" ],
                 [ "category", HOMALG_GRADED_MODULES.category ],
@@ -879,7 +879,7 @@ InstallMethod( LinearStrandOfTateResolution,
     
 end );
 
-InstallValue( Functor_LinearStrandOfTateResolution_ForGradedModules,
+BindGlobal( "Functor_LinearStrandOfTateResolution_ForGradedModules",
         CreateHomalgFunctor(
                 [ "name", "LinearStrandOfTateResolution" ],
                 [ "category", HOMALG_GRADED_MODULES.category ],
diff --git a/Modules/gap/OtherFunctors.gd b/Modules/gap/OtherFunctors.gd
@@ -17,8 +17,6 @@ DeclareGlobalFunction( "_Functor_DirectSum_OnModules" );
 
 DeclareGlobalFunction( "_Functor_DirectSum_OnMaps" );
 
-DeclareGlobalVariable( "Functor_DirectSum_for_fp_modules" );
-
 ####################################
 #
 # temporary
diff --git a/Modules/gap/OtherFunctors.gi b/Modules/gap/OtherFunctors.gi
@@ -134,7 +134,7 @@ InstallGlobalFunction( _Functor_DirectSum_OnMaps, ### defines: DirectSum (morphi
     
 end );
 
-InstallValue( Functor_DirectSum_for_fp_modules,
+BindGlobal( "Functor_DirectSum_for_fp_modules",
         CreateHomalgFunctor(
                 [ "name", "DirectSum" ],
                 [ "category", HOMALG_MODULES.category ],

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,6 @@ DeclareGlobalFunction( "_Functor_DirectSum_OnModules" );`
`17`	`17`
`18`	`18`	`DeclareGlobalFunction( "_Functor_DirectSum_OnMaps" );`
`19`	`19`
`20`		`-DeclareGlobalVariable( "Functor_DirectSum_for_fp_modules" );`
`21`		`-`
`22`	`20`	`####################################`
`23`	`21`	`#`
`24`	`22`	`# temporary`