Skip to content

Commit cdadc6b

Browse files
authored
Merge pull request #20484 from hrydgard/final-fixes
Fix D3D11 crash-on-exit. Update README.md and an URL
2 parents a900363 + 9e1c92f commit cdadc6b

File tree

4 files changed

+36
-2
lines changed

4 files changed

+36
-2
lines changed

README.md

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,18 @@ To download fresh development builds for Android, Windows and Mac, [go to the /d
2525

2626
For game compatibility, see [community compatibility feedback](https://report.ppsspp.org/games).
2727

28+
What's new in 1.19.1
29+
--------------------
30+
31+
- Fix selecting background image on Android ([#20477])
32+
- Fix RetroAchievements regression for multi-executable games ([#20469])
33+
- Possible fix for Mac audio device selection issue ([#20482])
34+
- Add workaround for Dragon's Lair not working with LLE scePsmf ([#20468])
35+
- Prevent trying to load obviously-corrupt CSO/CHD files ([#20466])
36+
- Fix regression for homebrew apps that request extra memory ([#20457])
37+
- Fix grid drawing in the various Robot Taisen games ([#20456])
38+
- Fix crash in UI when viewing a directory with multiple NPDRM ISOs ([#20453])
39+
2840
What's new in 1.19
2941
------------------
3042

@@ -337,4 +349,12 @@ What's new in 1.18
337349
[#19915]: https://github.com/hrydgard/ppsspp/issues/19915 "Android: Improve mouse input"
338350
[#19874]: https://github.com/hrydgard/ppsspp/issues/19874 "macOS/iOS: register font with CoreText"
339351
[#19668]: https://github.com/hrydgard/ppsspp/issues/19668 "File system perf part 1: Remove some unnecessary file access"
340-
[#20311]: https://github.com/hrydgard/ppsspp/issues/20311 "Automatically disable fast forward feature when doing multiplayer."
352+
[#20311]: https://github.com/hrydgard/ppsspp/issues/20311 "Automatically disable fast forward feature when doing multiplayer."
353+
[#20477]: https://github.com/hrydgard/ppsspp/issues/20477 "Fix background image selection on Android"
354+
[#20469]: https://github.com/hrydgard/ppsspp/issues/20469 "Fix RetroAchievements for multi-exe games, add some sanity checks"
355+
[#20482]: https://github.com/hrydgard/ppsspp/issues/20482 "SDL audio: Improve logging, don't auto-switch device during the first 3 seconds of execution"
356+
[#20468]: https://github.com/hrydgard/ppsspp/issues/20468 "Add workaround for scePsmf LLE not working with Dragon's Lair"
357+
[#20466]: https://github.com/hrydgard/ppsspp/issues/20466 "ISO loading: Check CSO and CHD files \"early\""
358+
[#20457]: https://github.com/hrydgard/ppsspp/issues/20457 "Fix homebrew apps that request large memory"
359+
[#20456]: https://github.com/hrydgard/ppsspp/issues/20456 "Fix grid drawing in Robot Taisen games."
360+
[#20453]: https://github.com/hrydgard/ppsspp/issues/20453 "libkirk concurrency fixes"

UI/IAPScreen.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ void IAPScreen::CreateViews() {
6969

7070
Choice *moreInfo = rightColumnItems->Add(new Choice(di->T("More info")));
7171
moreInfo->OnClick.Add([](UI::EventParams &) {
72-
System_LaunchUrl(LaunchUrlType::BROWSER_URL, "https://www.ppsspp.org/docs/reference/whygold/");
72+
System_LaunchUrl(LaunchUrlType::BROWSER_URL, "https://www.ppsspp.org/buygold_ios");
7373
return UI::EVENT_DONE;
7474
});
7575

Windows/EmuThread.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,7 @@ void MainThreadFunc() {
335335
g_graphicsContext->Shutdown();
336336

337337
delete g_graphicsContext;
338+
g_graphicsContext = nullptr;
338339

339340
RECT rc;
340341
if (console && GetWindowRect(console, &rc) && !IsIconic(console)) {

Windows/GPU/D3D11Context.cpp

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,19 @@ void D3D11Context::Shutdown() {
256256
}
257257
#endif
258258

259+
#ifdef _DEBUG
260+
d3dDebug_ = nullptr;
261+
d3dInfoQueue_ = nullptr;
262+
#endif
263+
264+
// Important that we release before we unload the DLL, otherwise we may crash on shutdown.
265+
bbRenderTargetTex_ = nullptr;
266+
bbRenderTargetView_ = nullptr;
267+
context1_ = nullptr;
268+
context_ = nullptr;
269+
device1_ = nullptr;
270+
device_ = nullptr;
259271
hWnd_ = nullptr;
272+
260273
UnloadD3D11();
261274
}

0 commit comments

Comments
 (0)