fix(shrinkBins): sum the squared differences not square the sum

jamespeapen · jamespeapen · commit 2778b4d818a0 · 2025-03-26T13:25:10.000-04:00
for targeted shrinkage
diff --git a/R/shrinkBins.R b/R/shrinkBins.R
@@ -140,7 +140,7 @@ shrinkBins <- function(
     c <- sd(x[targets])
   } else {
     ## targeted shrinkage
-    c <- 1 - ((length(x) - 3) * (sd(x[targets])^2) / sum(x - grand.mean)^2)
+    c <- 1 - ((length(x) - 3) * (sd(x[targets])^2) / sum((x - grand.mean)^2))
   }
 
   return(grand.mean + c * (x - grand.mean))

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ shrinkBins <- function(`
`140`	`140`	`c <- sd(x[targets])`
`141`	`141`	`} else {`
`142`	`142`	`## targeted shrinkage`
`143`		`- c <- 1 - ((length(x) - 3) * (sd(x[targets])^2) / sum(x - grand.mean)^2)`
	`143`	`+ c <- 1 - ((length(x) - 3) * (sd(x[targets])^2) / sum((x - grand.mean)^2))`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`return(grand.mean + c * (x - grand.mean))`