Feature/feature tracking for sheet measurements (#1068)

* Added feature tracking

* cleaner and more precise

Author: Maxime-Brassard

change/@itwin-measure-tools-react-02a76df8-b8f7-4ea6-a9e7-2de941b7f1b9.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fixed imports and naming",
+  "packageName": "@itwin/measure-tools-react",
+  "email": "email not defined",
+  "dependentChangeType": "patch"
+}

packages/itwin/measure-tools/src/api/FeatureTracking.ts

@@ -216,4 +216,24 @@ export class MeasureToolsFeatures {
       guid: "ef4bba9e-69f1-4f73-9db9-e176dd9335a4",
     };
   }
+
+  // Sheet measurement tools
+  public static get Tools_MeasureDistance_createdInSheet(): Feature {
+    return {
+      name: "SMT_Tools_MeasureDistance_createdInSheet",
+      guid: "f3fde39b-c9d6-488a-a39a-2a253ff106d5"
+    }
+  }
+  public static get Tools_MeasureArea_createdInSheet(): Feature {
+    return {
+      name: "SMT_Tools_MeasureArea_createdInSheet",
+      guid: "cd36e911-a472-4560-94e6-2128fd95f31c"
+    }
+  }
+  public static get Tools_MeasureLocation_createdInSheet(): Feature {
+    return {
+      name: "SMT_Tools_MeasureLocation_createdInSheet",
+      guid: "10237379-3f9f-4f4a-93f7-fe453cb730a6"
+    }
+  }
 }

packages/itwin/measure-tools/src/tools/MeasureAreaTool.ts

@@ -19,15 +19,15 @@ import {
   ToolAssistanceInputMethod,
 } from "@itwin/core-frontend";
 import type { Feature } from "../api/FeatureTracking";
-import { MeasureToolsFeatures } from "../api/FeatureTracking";
+import { FeatureTracking, MeasureToolsFeatures } from "../api/FeatureTracking";
 import { MeasurementToolBase } from "../api/MeasurementTool";
 import { MeasurementViewTarget } from "../api/MeasurementViewTarget";
 import type { AreaMeasurement } from "../measurements/AreaMeasurement";
 import { MeasureAreaToolModel } from "../toolmodels/MeasureAreaToolModel";
 import { MeasureTools } from "../MeasureTools";
 import { SheetMeasurementsHelper } from "../api/SheetMeasurementHelper";
 import type { DrawingMetadata } from "../api/Measurement";
-import { DrawingDataCache } from "../api/DrawingTypeDataCache";
+import { ViewHelper } from "../api/ViewHelper";
 
 export class MeasureAreaTool extends MeasurementToolBase<
 AreaMeasurement,
@@ -198,6 +198,8 @@ MeasureAreaToolModel
   ): Promise<EventHandled> {
     // Attempt to close polygon
     if (this.toolModel.tryCommitMeasurement()) {
+      if (this._enableSheetMeasurements && ev.viewport !== undefined && ViewHelper.isSheetView(ev.viewport))
+        FeatureTracking.notifyFeature(MeasureToolsFeatures.Tools_MeasureDistance_createdInSheet)
       await this.onReinitialize();
       return EventHandled.Yes;
     }

packages/itwin/measure-tools/src/tools/MeasureDistanceTool.ts

@@ -18,7 +18,7 @@ import {
   ToolAssistanceInputMethod,
 } from "@itwin/core-frontend";
 import type { Feature } from "../api/FeatureTracking";
-import { MeasureToolsFeatures } from "../api/FeatureTracking";
+import { FeatureTracking, MeasureToolsFeatures } from "../api/FeatureTracking";
 import { MeasurementToolBase } from "../api/MeasurementTool";
 import { MeasurementViewTarget } from "../api/MeasurementViewTarget";
 import type { DistanceMeasurement } from "../measurements/DistanceMeasurement";
@@ -27,6 +27,7 @@ import { MeasureDistanceToolModel } from "../toolmodels/MeasureDistanceToolModel
 import { SheetMeasurementsHelper } from "../api/SheetMeasurementHelper";
 import type { DrawingMetadata } from "../api/Measurement";
 import { type DialogItem, type DialogItemValue, type DialogPropertySyncItem, PropertyDescriptionHelper } from "@itwin/appui-abstract";
+import { ViewHelper } from "../api/ViewHelper";
 
 export class MeasureDistanceTool extends MeasurementToolBase<
 DistanceMeasurement,
@@ -100,6 +101,8 @@ MeasureDistanceToolModel
       MeasureDistanceToolModel.State.SetEndPoint === this.toolModel.currentState
     ) {
       this.toolModel.setEndPoint(viewType, ev.point, false);
+      if (this._enableSheetMeasurements && ViewHelper.isSheetView(ev.viewport))
+        FeatureTracking.notifyFeature(MeasureToolsFeatures.Tools_MeasureDistance_createdInSheet)
       await this.onReinitialize();
 
       // Trigger another button event to use as the start point of the next measurement

packages/itwin/measure-tools/src/tools/MeasureLocationTool.ts

@@ -4,8 +4,7 @@
 *--------------------------------------------------------------------------------------------*/
 
 import { GeoServiceStatus } from "@itwin/core-bentley";
-import type { CurvePrimitive } from "@itwin/core-geometry";
-import { GeometryQuery, IModelJson, Vector3d } from "@itwin/core-geometry";
+import { Vector3d } from "@itwin/core-geometry";
 import { IModelError } from "@itwin/core-common";
 import type {
   BeButtonEvent,
@@ -23,7 +22,7 @@ import {
   ToolAssistanceInputMethod,
 } from "@itwin/core-frontend";
 import type { Feature } from "../api/FeatureTracking";
-import { MeasureToolsFeatures } from "../api/FeatureTracking";
+import { FeatureTracking, MeasureToolsFeatures } from "../api/FeatureTracking";
 import { MeasurementToolBase } from "../api/MeasurementTool";
 import { MeasurementViewTarget } from "../api/MeasurementViewTarget";
 import type { LocationMeasurement } from "../measurements/LocationMeasurement";
@@ -34,7 +33,7 @@ import type { DialogItem, DialogItemValue, DialogPropertySyncItem } from "@itwin
 import { PropertyDescriptionHelper } from "@itwin/appui-abstract";
 import { SheetMeasurementsHelper } from "../api/SheetMeasurementHelper";
 import type { DrawingMetadata, DrawingMetadataProps } from "../api/Measurement";
-import { DrawingDataCache } from "../api/DrawingTypeDataCache";
+import { ViewHelper } from "../api/ViewHelper";
 
 /** Tool that measure precise locations */
 export class MeasureLocationTool extends MeasurementToolBase<
@@ -92,6 +91,8 @@ MeasureLocationToolModel
 
     const props = await this.createLocationProps(ev, true);
     this.toolModel.addLocation(props, false);
+    if (this._enableSheetMeasurements && ViewHelper.isSheetView(ev.viewport))
+      FeatureTracking.notifyFeature(MeasureToolsFeatures.Tools_MeasureDistance_createdInSheet)
     this.updateToolAssistance();
     return EventHandled.Yes;
   }