Skip to content

Commit 01fabe2

Browse files
committed
simplified boolean
1 parent 118f3c2 commit 01fabe2

File tree

1 file changed

+2
-3
lines changed
  • packages/itwin/grouping-mapping-widget/src/components/Groups/QueryBuilder

1 file changed

+2
-3
lines changed

packages/itwin/grouping-mapping-widget/src/components/Groups/QueryBuilder/QueryBuilder.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ export class QueryBuilder {
165165
this.addRelatedToQuery(i, propertiesField, propertyName, propertyValue);
166166
} else {
167167
// Model properties with display values always need quotes
168-
const needsQuote = modeledElement ? true : this.needsQuote(propertiesField);
168+
const needsQuote = !!modeledElement || this.needsQuote(propertiesField);
169169
this.addPropertyToQuery(i, className, propertyName, propertyValue, needsQuote, isCategory, modeledElement, isAspect);
170170
}
171171
}
@@ -276,8 +276,7 @@ export class QueryBuilder {
276276
// Model properties should be kept separate to ensure proper JOIN generation
277277
const foundPropertyClass = this.query.unions[unionIndex].properties.find((p) => {
278278
// Don't merge Model properties with regular properties
279-
if (modeledElementClass && !p.modeledElementClass) return false;
280-
if (!modeledElementClass && p.modeledElementClass) return false;
279+
if (!!modeledElementClass !== !!p.modeledElementClass) return false;
281280
return p.className === className;
282281
});
283282

0 commit comments

Comments
 (0)