delay calling MC4WP_Ninja_Forms_Action::get_list_settings until init hook

dannyvankooten · dannyvankooten · commit 5a872644b4d0 · 2025-01-22T09:58:37.000+01:00
diff --git a/integrations/ninja-forms/class-action.php b/integrations/ninja-forms/class-action.php
@@ -57,9 +57,7 @@ public function __construct()
 
         add_action('wp_ajax_nf_' . $this->_name . '_get_lists', [$this, '_get_lists']);
         add_action('init', [$this, 'translate_props']);
-
-
-        $this->get_list_settings();
+        add_action('init', [$this, 'get_list_settings']);
     }
 
     public function translate_props()
@@ -147,7 +145,7 @@ private function get_lists()
         return $return;
     }
 
-    private function get_list_settings()
+    public function get_list_settings()
     {
         $label_defaults = [
             'list'   => 'List',

Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,7 @@ public function __construct()`
`57`	`57`
`58`	`58`	`add_action('wp_ajax_nf_' . $this->_name . '_get_lists', [$this, '_get_lists']);`
`59`	`59`	`add_action('init', [$this, 'translate_props']);`
`60`		`-`
`61`		`-`
`62`		`- $this->get_list_settings();`
	`60`	`+ add_action('init', [$this, 'get_list_settings']);`
`63`	`61`	`}`
`64`	`62`
`65`	`63`	`public function translate_props()`
`@@ -147,7 +145,7 @@ private function get_lists()`
`147`	`145`	`return $return;`
`148`	`146`	`}`
`149`	`147`
`150`		`- private function get_list_settings()`
	`148`	`+ public function get_list_settings()`
`151`	`149`	`{`
`152`	`150`	`$label_defaults = [`
`153`	`151`	`'list' => 'List',`