do not call parent constructor in Ninja Forms Action class because it calls gettext too early

dannyvankooten · dannyvankooten · commit 7e35173834a1 · 2025-01-03T16:40:56.000+01:00
diff --git a/integrations/ninja-forms/class-action.php b/integrations/ninja-forms/class-action.php
@@ -1,5 +1,7 @@
 <?php
 
+use ParagonIE\Sodium\Core\Curve25519\Ge\P2;
+
 if (! defined('ABSPATH')) {
 	exit;
 }
@@ -22,8 +24,6 @@ class MC4WP_Ninja_Forms_Action extends NF_Abstracts_Action
 
 	public function __construct()
 	{
-		parent::__construct();
-
 		$this->_settings['double_optin']    = array(
 			'name'    => 'double_optin',
 			'type'    => 'select',
@@ -64,6 +64,7 @@ public function __construct()
 		add_action('wp_ajax_nf_' . $this->_name . '_get_lists', array($this, '_get_lists'));
 		add_action('init', array($this, 'translate_props'));
 
+
         $this->get_list_settings();
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
`1`	`1`	`<?php`
`2`	`2`
	`3`	`+use ParagonIE\Sodium\Core\Curve25519\Ge\P2;`
	`4`	`+`
`3`	`5`	`if (! defined('ABSPATH')) {`
`4`	`6`	`exit;`
`5`	`7`	`}`
`@@ -22,8 +24,6 @@ class MC4WP_Ninja_Forms_Action extends NF_Abstracts_Action`
`22`	`24`
`23`	`25`	`public function __construct()`
`24`	`26`	`{`
`25`		`- parent::__construct();`
`26`		`-`
`27`	`27`	`$this->_settings['double_optin'] = array(`
`28`	`28`	`'name' => 'double_optin',`
`29`	`29`	`'type' => 'select',`
`@@ -64,6 +64,7 @@ public function __construct()`
`64`	`64`	`add_action('wp_ajax_nf_' . $this->_name . '_get_lists', array($this, '_get_lists'));`
`65`	`65`	`add_action('init', array($this, 'translate_props'));`
`66`	`66`
	`67`	`+`
`67`	`68`	`$this->get_list_settings();`
`68`	`69`	`}`
`69`	`70`