run phpcs on tests/ directory too

Author: dannyvankooten

includes/class-debug-log.php

@@ -10,26 +10,26 @@ class MC4WP_Debug_Log
     /**
      * Detailed debug information
      */
-    const DEBUG = 100;
+    public const DEBUG = 100;
 
     /**
      * Interesting events
      *
      * Examples: Visitor subscribed
      */
-    const INFO = 200;
+    public const INFO = 200;
 
     /**
      * Exceptional occurrences that are not errors
      *
      * Examples: User already subscribed
      */
-    const WARNING = 300;
+    public const WARNING = 300;
 
     /**
      * Runtime errors
      */
-    const ERROR = 400;
+    public const ERROR = 400;
 
     /**
      * Logging levels from syslog protocol defined in RFC 5424

includes/class-queue.php

@@ -25,7 +25,7 @@ class MC4WP_Queue
     /**
      * @var int
      */
-    const MAX_JOB_COUNT = 1000;
+    private const MAX_JOB_COUNT = 1000;
 
     /**
      * MC4WP_Ecommerce_Queue constructor.

includes/forms/class-output-manager.php

@@ -16,7 +16,7 @@ class MC4WP_Form_Output_Manager
     /**
      * @const string
      */
-    const SHORTCODE = 'mc4wp_form';
+    private const SHORTCODE = 'mc4wp_form';
 
     /**
      * Add hooks

integrations/prosopo-procaptcha/class-procaptcha.php

@@ -1,17 +1,15 @@
 <?php
 
-defined('ABSPATH') or exit;
-
 /**
  * Class MC4WP_Procaptcha
  *
  * @private
  */
 class MC4WP_Procaptcha
 {
-    const SCRIPT_URL      = 'https://js.prosopo.io/js/procaptcha.bundle.js';
-    const FORM_FIELD_NAME = 'procaptcha-response';
-    const API_URL         = 'https://api.prosopo.io/siteverify';
+    private const SCRIPT_URL      = 'https://js.prosopo.io/js/procaptcha.bundle.js';
+    private const FORM_FIELD_NAME = 'procaptcha-response';
+    private const API_URL         = 'https://api.prosopo.io/siteverify';
 
     /**
      * @var MC4WP_Procaptcha

phpcs.xml

@@ -7,6 +7,7 @@
   <file>includes/</file>
   <file>integrations/</file>
   <file>config/</file>
+  <file>tests/</file>
   <file>sample-code-snippets/</file>
   <exclude-pattern>*\.(html|css|js|md|json|xml|sh)</exclude-pattern>
   <rule ref="Generic.Arrays.DisallowLongArraySyntax.Found"/>

tests/ContainerTest.php

@@ -9,7 +9,6 @@
  */
 class ContainerTest extends TestCase
 {
-
     /**
      * @covers MC4WP_Container::get
      */

tests/DebugLogReaderTest.php

@@ -4,7 +4,6 @@
 
 class DebugLogReaderTest extends TestCase
 {
-
     /**
      * @var string
      */
@@ -13,10 +12,10 @@ class DebugLogReaderTest extends TestCase
     /**
      * @var string
      */
-    protected array $sample_log_lines = array(
+    protected array $sample_log_lines = [
         'eCommerce360 > Successfully added order 101',
         'eCommerce360 > Order 101 deleted',
-    );
+    ];
 
     /**
      * DebugLogReaderTest constructor.

tests/DebugLogTest.php

@@ -4,7 +4,6 @@
 
 class DebugLogTest extends TestCase
 {
-
     /**
      * @var string
      */
@@ -121,7 +120,7 @@ public function test_error()
     /**
      * Remove log files after each test.
      */
-    public function tearDown() : void
+    public function tearDown(): void
     {
         if (file_exists($this->file)) {
             unlink($this->file);

tests/FieldFormatterTest.php

@@ -1,4 +1,5 @@
 <?php
+
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -8,22 +9,21 @@
  */
 class FieldFormatterTest extends TestCase
 {
-
     /**
      * @covers MC4WP_Field_Formatter::address
      */
     public function test_address()
     {
         $formatter = new MC4WP_Field_Formatter();
 
-        $address = array(
+        $address = [
             'addr1' => "795 E DRAGRAM",
             'addr2' => '',
             'city' => 'TUCSON',
             'state' => 'AZ',
             'zip' => '85705',
             'country' => 'USA'
-        );
+        ];
 
         // should accept string
         $value = $formatter->address(join(',', $address));
@@ -39,7 +39,7 @@ public function test_address()
         self::assertArrayHasKey('city', $value);
 
         // partial array value
-        $value = $formatter->address(array( 'city' => $address['city'] ));
+        $value = $formatter->address([ 'city' => $address['city'] ]);
         self::assertEquals($value['city'], $address['city']);
         self::assertArrayHasKey('addr1', $value);
     }
@@ -62,11 +62,11 @@ public function test_birthday()
         self::assertEquals($birthday, $value);
 
         // array with "day" and "month"
-        $value = $formatter->birthday(array( 'day' => 29, 'month' => 7 ));
+        $value = $formatter->birthday([ 'day' => 29, 'month' => 7 ]);
         self::assertEquals($birthday, $value);
 
         // simple array
-        $value = $formatter->birthday(array( 29, 7 ));
+        $value = $formatter->birthday([ 29, 7 ]);
         self::assertEquals($birthday, $value);
 
         // full year
@@ -95,7 +95,7 @@ public function test_date()
         self::assertEquals($date, $value);
 
         // array keys
-        $value = $formatter->date(array( 'day' => 5, 'month' => 5, 'year' => 2016 ));
+        $value = $formatter->date([ 'day' => 5, 'month' => 5, 'year' => 2016 ]);
         self::assertEquals($date, $value);
     }
 
@@ -106,12 +106,12 @@ public function test_boolean()
     {
         $formatter = new MC4WP_Field_Formatter();
 
-        $falsey_tests = array( 'false', '0', 0, false );
+        $falsey_tests = [ 'false', '0', 0, false ];
         foreach ($falsey_tests as $test) {
             self::assertEquals(false, $formatter->boolean($test));
         }
 
-        $truthy_tests = array( 'true', '1', 1, true );
+        $truthy_tests = [ 'true', '1', 1, true ];
         foreach ($truthy_tests as $test) {
             self::assertEquals(true, $formatter->boolean($test));
         }
@@ -124,15 +124,15 @@ public function test_language()
     {
         $formatter = new MC4WP_Field_Formatter();
 
-        $tests = array(
+        $tests = [
             'pt_PT' => 'pt_PT',
             'es_ES' => 'es_ES',
             'fr_CA' => 'fr_CA',
             'pt_BR' => 'pt',
             'fr_FR' => 'fr',
             'nl_NL' => 'nl',
             'en_US' => 'en',
-        );
+        ];
 
         foreach ($tests as $input => $output) {
             self::assertEquals($formatter->language($input), $output);

tests/FieldGuesserTest.php

@@ -1,4 +1,5 @@
 <?php
+
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -8,22 +9,21 @@
  */
 class FieldGuesserTest extends TestCase
 {
-
     /**
      * @covers MC4WP_Field_Guesser::namespaced
      */
     public function test_namespaced()
     {
-        $data = array(
+        $data = [
             'prefix-foo' => 'bar',
             'foo' => 'barbar'
-        );
+        ];
 
         $instance = new MC4WP_Field_Guesser($data);
         self::assertEquals(
-            array(
+            [
             'FOO' => 'bar'
-            ),
+            ],
             $instance->namespaced('prefix-')
         );
     }
@@ -33,19 +33,19 @@ public function test_namespaced()
      */
     public function test_guessed()
     {
-        $data = array(
+        $data = [
             'name' => 'Danny van Kooten',
             'first-name' => 'Danny',
             'lname' => 'van Kooten'
-        );
+        ];
 
         $instance = new MC4WP_Field_Guesser($data);
         self::assertEquals(
-            array(
+            [
                 'NAME' => 'Danny van Kooten',
                 'FNAME' => 'Danny',
                 'LNAME' => "van Kooten"
-            ),
+            ],
             $instance->guessed()
         );
     }
@@ -55,30 +55,30 @@ public function test_guessed()
      */
     public function test_combine()
     {
-        $data = array(
+        $data = [
             'name' => 'Danny van Kooten',
             'prefix-email' => 'johndoe@email.com',
             'foo' => 'bar'
-        );
+        ];
 
         $instance = new MC4WP_Field_Guesser($data);
-        $result = $instance->combine(array( 'namespaced', 'guessed' ));
+        $result = $instance->combine([ 'namespaced', 'guessed' ]);
 
         self::assertEquals($result['NAME'], $data['name']);
         self::assertEquals($result['EMAIL'], $data['prefix-email']);
         self::assertArrayNotHasKey('foo', $result);
 
         // test order (latter overwrites former)
-        $data = array(
+        $data = [
             'name' => 'Danny van Kooten',
             'mc4wp-name' => 'Danny Janssen'
-        );
+        ];
 
         $instance = new MC4WP_Field_Guesser($data);
-        $result = $instance->combine(array( 'namespaced', 'guessed' ));
+        $result = $instance->combine([ 'namespaced', 'guessed' ]);
         self::assertEquals($result['NAME'], $data['name']);
 
-        $result = $instance->combine(array( 'guessed', 'namespaced' ));
+        $result = $instance->combine([ 'guessed', 'namespaced' ]);
         self::assertEquals($result['NAME'], $data['mc4wp-name']);
     }
 }