Enhancing Validation for sRated of HpTypeInput

Author: danielfeismann

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 - Enhanced check for invalid field names in sources [#1383](https://github.com/ie3-institute/PowerSystemDataModel/issues/1383)
 - Enhancing value retrieval in `TimeSeriesSource` [1280](https://github.com/ie3-institute/PowerSystemDataModel/issues/1280)
+- Enhancing Validation for sRated of `HpTypeInput` [1394](https://github.com/ie3-institute/PowerSystemDataModel/issues/1394)
 
 ### Fixed
 

src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java

@@ -337,6 +337,7 @@ private static List<Try<Void, InvalidEntityException>> checkHp(HpInput hpInput)
    * Validates a HpTypeInput if:
    *
    * <ul>
+   *   <li>its rated power is positive
    *   <li>its rated thermal power is positive
    * </ul>
    *
@@ -347,7 +348,10 @@ private static Try<Void, InvalidEntityException> checkHpType(HpTypeInput hpTypeI
     return Try.ofVoid(
         () ->
             detectZeroOrNegativeQuantities(
-                new Quantity<?>[] {hpTypeInput.getpThermal()}, hpTypeInput),
+                new Quantity<?>[] {
+                  hpTypeInput.getsRated(), hpTypeInput.getpThermal(),
+                },
+                hpTypeInput),
         InvalidEntityException.class);
   }
 

src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy

@@ -294,8 +294,9 @@ class SystemParticipantValidationUtilsTest extends Specification {
     ex.message.contains(expectedException.message)
 
     where:
-    invalidHpType                                                                                           || expectedException
-    new HpTypeInput(uuid, id, capex, opex, sRated, cosPhiRated, Quantities.getQuantity(0, ACTIVE_POWER_IN)) || new InvalidEntityException("The following quantities have to be positive: 0 kW", invalidHpType)
+    invalidHpType                                                                                             || expectedException
+    new HpTypeInput(uuid, id, capex, opex, Quantities.getQuantity(0, ACTIVE_POWER_IN), cosPhiRated, pThermal) || new InvalidEntityException("The following quantities have to be positive: 0 kW", invalidHpType)
+    new HpTypeInput(uuid, id, capex, opex, sRated, cosPhiRated, Quantities.getQuantity(0, ACTIVE_POWER_IN))   || new InvalidEntityException("The following quantities have to be positive: 0 kW", invalidHpType)
   }
 
   // Load