Skip to content

Commit a23b2ed

Browse files
Merge branch 'dev' into df/#1409-spotless-java-format
# Conflicts: # CHANGELOG.md
2 parents f7fe531 + 9183cb1 commit a23b2ed

File tree

4 files changed

+14
-6
lines changed

4 files changed

+14
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414

1515
### Changed
1616
- Updated CI-Pipeline to run task `Deploy` and `Staging` only for `Main` [#1403](https://github.com/ie3-institute/PowerSystemDataModel/issues/1403)
17+
- Extend `GermanVoltageLevelUtils` with more synonymousIds [#143](https://github.com/ie3-institute/PowerSystemDataModel/issues/143)
1718
- Change spotless to use googleJavaFormat('1.28.0') [#1409](https://github.com/ie3-institute/PowerSystemDataModel/issues/1409)
1819

1920
## [8.1.0] - 2025-07-25

src/main/java/edu/ie3/datamodel/models/voltagelevels/GermanVoltageLevelUtils.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,28 +27,28 @@ public class GermanVoltageLevelUtils {
2727
new CommonVoltageLevel(
2828
"Niederspannung",
2929
Quantities.getQuantity(0.4, KILOVOLT),
30-
new HashSet<>(Arrays.asList("lv", "ns")),
30+
new HashSet<>(Arrays.asList("lv", "ns", "0.4kV")),
3131
new RightOpenInterval<>(
3232
Quantities.getQuantity(0d, KILOVOLT), Quantities.getQuantity(10d, KILOVOLT)));
3333
public static final CommonVoltageLevel MV_10KV =
3434
new CommonVoltageLevel(
3535
MS,
3636
Quantities.getQuantity(10d, KILOVOLT),
37-
new HashSet<>(Arrays.asList("ms", "mv", "ms_10kv", "mv_10kV")),
37+
new HashSet<>(Arrays.asList("ms", "mv", "ms_10kv", "mv_10kV", "10.0kV", "10kV")),
3838
new RightOpenInterval<>(
3939
Quantities.getQuantity(10d, KILOVOLT), Quantities.getQuantity(20d, KILOVOLT)));
4040
public static final CommonVoltageLevel MV_20KV =
4141
new CommonVoltageLevel(
4242
MS,
4343
Quantities.getQuantity(20d, KILOVOLT),
44-
new HashSet<>(Arrays.asList("ms", "mv", "ms_20kv", "mv_20kV")),
44+
new HashSet<>(Arrays.asList("ms", "mv", "ms_20kv", "mv_20kV", "20.0kV", "20kV")),
4545
new RightOpenInterval<>(
4646
Quantities.getQuantity(20d, KILOVOLT), Quantities.getQuantity(30d, KILOVOLT)));
4747
public static final CommonVoltageLevel MV_30KV =
4848
new CommonVoltageLevel(
4949
MS,
5050
Quantities.getQuantity(30d, KILOVOLT),
51-
new HashSet<>(Arrays.asList("ms", "mv", "ms_30kv", "mv_30kV")),
51+
new HashSet<>(Arrays.asList("ms", "mv", "ms_30kv", "mv_30kV", "30.0kV", "30kV")),
5252
new RightOpenInterval<>(
5353
Quantities.getQuantity(30d, KILOVOLT), Quantities.getQuantity(110d, KILOVOLT)));
5454
public static final CommonVoltageLevel HV =

src/test/groovy/edu/ie3/datamodel/models/GermanVoltageLevelUtilsTest.groovy

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,16 @@ class GermanVoltageLevelUtilsTest extends Specification {
2424
where:
2525
id || vRated || expected
2626
"NS" || Quantities.getQuantity(0.4d, KILOVOLT) || LV
27+
"0.4kV" || Quantities.getQuantity(0.4d, KILOVOLT) || LV
28+
"10.0kV"|| Quantities.getQuantity(10d, KILOVOLT) || MV_10KV
29+
"10kV" || Quantities.getQuantity(10d, KILOVOLT) || MV_10KV
2730
"MS" || Quantities.getQuantity(15d, KILOVOLT) || MV_10KV
2831
"MS" || Quantities.getQuantity(20d, KILOVOLT) || MV_20KV
32+
"20.0kV"|| Quantities.getQuantity(20d, KILOVOLT) || MV_20KV
33+
"20kV" || Quantities.getQuantity(20d, KILOVOLT) || MV_20KV
2934
"MS" || Quantities.getQuantity(35d, KILOVOLT) || MV_30KV
35+
"30.0kV"|| Quantities.getQuantity(30d, KILOVOLT) || MV_30KV
36+
"30kV" || Quantities.getQuantity(30d, KILOVOLT) || MV_30KV
3037
"HS" || Quantities.getQuantity(110d, KILOVOLT) || HV
3138
"HoeS" || Quantities.getQuantity(220d, KILOVOLT) || EHV_220KV
3239
"HoeS" || Quantities.getQuantity(380d, KILOVOLT) || EHV_380KV

src/test/groovy/edu/ie3/datamodel/utils/ContainerUtilsTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,8 +278,8 @@ class ContainerUtilsTest extends Specification {
278278
InvalidGridException ex = thrown()
279279
ex.message == "There are 2 voltage levels apparent, although only one is expected. Following voltage levels" +
280280
" are present: CommonVoltageLevel{id='Mittelspannung', nominalVoltage=10 kV, synonymousIds=" +
281-
"[Mittelspannung, ms, ms_10kv, mv, mv_10kV], voltageRange=Interval [10 kV, 20 kV)}, CommonVoltageLevel" +
282-
"{id='Mittelspannung', nominalVoltage=20 kV, synonymousIds=[Mittelspannung, ms, ms_20kv, mv, mv_20kV], " +
281+
"[10.0kV, 10kV, Mittelspannung, ms, ms_10kv, mv, mv_10kV], voltageRange=Interval [10 kV, 20 kV)}, CommonVoltageLevel" +
282+
"{id='Mittelspannung', nominalVoltage=20 kV, synonymousIds=[20.0kV, 20kV, Mittelspannung, ms, ms_20kv, mv, mv_20kV], " +
283283
"voltageRange=Interval [20 kV, 30 kV)}"
284284
}
285285

0 commit comments

Comments
 (0)