Improving the exceptions thrown by methods in UniquenessValidationUtils.

Author: staudtMarius

src/main/java/edu/ie3/datamodel/exceptions/DuplicateEntitiesException.java

@@ -20,6 +20,6 @@ public DuplicateEntitiesException(
         "The following exception(s) occurred while checking the uniqueness of '"
             + entityName
             + "' entities: \n"
-            + ExceptionUtils.combineExceptions(exceptions));
+            + ExceptionUtils.combineMessages(exceptions));
   }
 }

src/main/java/edu/ie3/datamodel/utils/ExceptionUtils.java

@@ -13,6 +13,24 @@ private ExceptionUtils() {
     throw new IllegalStateException("Utility classes cannot be instantiated");
   }
 
+  /**
+   * Creates a string containing multiple exception messages.
+   *
+   * @param exceptions list of exceptions
+   * @return str containing the messages
+   */
+  public static String combineMessages(List<? extends Exception> exceptions) {
+    String messageSeparator = "\n ";
+
+    String messages =
+        exceptions.stream()
+            .map(Throwable::getMessage)
+            .reduce("", (a, b) -> a + messageSeparator + b);
+
+    // some formating
+    return messages.replace("\n", "\n       ").replaceFirst(messageSeparator, "");
+  }
+
   /**
    * Creates a string containing multiple exception messages.
    *

src/test/groovy/edu/ie3/datamodel/utils/validation/UniquenessValidationUtilsTest.groovy

@@ -98,7 +98,7 @@ class UniquenessValidationUtilsTest extends Specification {
     then:
     DuplicateEntitiesException de = thrown()
     de.message == "The following exception(s) occurred while checking the uniqueness of 'AssetInput' entities: \n" +
-        "       edu.ie3.datamodel.exceptions.DuplicateEntitiesException: 'DummyAssetInput' entities with duplicated String key, but different field values found! Affected primary keys: [first]"
+        "       'DummyAssetInput' entities with duplicated String key, but different field values found! Affected primary keys: [first]"
   }
 
   def "Checking if result entities are unique"() {