From b6f96fcb34636b9236e356d3165507b5ee653069 Mon Sep 17 00:00:00 2001
From: pierrepetersmeier <155652256+pierrepetersmeier@users.noreply.github.com>
Date: Fri, 23 May 2025 13:15:07 +0200
Subject: [PATCH 1/5] =?UTF-8?q?Extend=20azimuth=20angle=20range=20to=20[-1?=
 =?UTF-8?q?80=C2=B0,=20180=C2=B0]=20for=20PV=20inputs?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 CHANGELOG.md                                           |  1 +
 docs/readthedocs/models/input/participant/pv.md        |  3 +--
 .../validation/SystemParticipantValidationUtils.java   | 10 +++++-----
 .../SystemParticipantValidationUtilsTest.groovy        |  2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 37d4cc181..c8617d055 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 - Updated dependabot workflow and added CODEOWNERS [#1328](https://github.com/ie3-institute/PowerSystemDataModel/issues/1328)
+- Extend azimuth angle range to [-180°, 180°] for PV inputs [#1330](https://github.com/ie3-institute/PowerSystemDataModel/issues/1330)
 
 ## [7.0.0] - 2025-05-08
 
diff --git a/docs/readthedocs/models/input/participant/pv.md b/docs/readthedocs/models/input/participant/pv.md
index f91f1801b..c8b4bcb47 100644
--- a/docs/readthedocs/models/input/participant/pv.md
+++ b/docs/readthedocs/models/input/participant/pv.md
@@ -44,8 +44,7 @@ Detailed model of a photovoltaic power plant.
 
    * - azimuth
      - °
-     - Inclination in a compass direction
-       South = 0°, West = 90°, East = -90°
+     - South = 0°, West = 90°, East = -90°, North = +/- 180°  
 
    * - etaConv
      - %
diff --git a/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java b/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
index 790bca28b..35930dc11 100644
--- a/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
+++ b/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
@@ -393,7 +393,7 @@ private static List<Try<Void, InvalidEntityException>> checkLoad(LoadInput loadI
    * <ul>
    *   <li>its rated apparent power is not negative
    *   <li>its albedo value of the plant's surrounding is between 0 and 1
-   *   <li>its inclination in a compass direction (azimuth) is between -90° and 90°
+   *   <li>its inclination in a compass direction (azimuth) is between -180° and 180°
    *   <li>its efficiency of the asset's inverter (etaConv) is between 0% and 100%
    *   <li>its tilted inclination from horizontal (elevation angle) is between 0° and 90°
    *   <li>its rated power factor is between 0 and 1
@@ -431,17 +431,17 @@ private static void checkAlbedo(PvInput pvInput) throws InvalidEntityException {
   }
 
   /**
-   * Check if azimuth angle of pvInput is between -90° and 90°
+   * Check if azimuth angle of pvInput is between -180° and 180°
    *
    * @param pvInput PvInput to validate
    */
   private static void checkAzimuth(PvInput pvInput) throws InvalidEntityException {
-    if (pvInput.getAzimuth().isLessThan(Quantities.getQuantity(-90d, AZIMUTH))
-        || pvInput.getAzimuth().isGreaterThan(Quantities.getQuantity(90d, AZIMUTH)))
+    if (pvInput.getAzimuth().isLessThan(Quantities.getQuantity(-180d, AZIMUTH))
+        || pvInput.getAzimuth().isGreaterThan(Quantities.getQuantity(180d, AZIMUTH)))
       throw new InvalidEntityException(
           "Azimuth angle of "
               + pvInput.getClass().getSimpleName()
-              + " must be between -90° (east) and 90° (west)",
+              + " must be between  0° (south), 90° (west), -90° (east), +/- 180° (north)",
           pvInput);
   }
 
diff --git a/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy b/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
index c89d7d005..add28c7b1 100644
--- a/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
+++ b/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
@@ -365,7 +365,7 @@ class SystemParticipantValidationUtilsTest extends Specification {
     invalidPV                                                                                                            || expectedSize || expectedException
     SystemParticipantTestData.pvInput.copy().sRated(Quantities.getQuantity(-25d, ACTIVE_POWER_IN)).build()               || 1            || new InvalidEntityException("The following quantities have to be zero or positive: -25 kVA", invalidPV)
     SystemParticipantTestData.pvInput.copy().albedo(2).build()                                                           || 1            || new InvalidEntityException("Albedo of the plant's surrounding of PvInput must be between 0 and 1", invalidPV)
-    SystemParticipantTestData.pvInput.copy().azimuth(Quantities.getQuantity(-100d, AZIMUTH)).build()                     || 1            || new InvalidEntityException("Azimuth angle of PvInput must be between -90° (east) and 90° (west)", invalidPV)
+    SystemParticipantTestData.pvInput.copy().azimuth(Quantities.getQuantity(-181d, AZIMUTH)).build()                     || 1            || new InvalidEntityException("Azimuth angle of PvInput must be between -90° (east) and 90° (west)", invalidPV)
     SystemParticipantTestData.pvInput.copy().etaConv(Quantities.getQuantity(110d, EFFICIENCY)).build()                   || 1            || new InvalidEntityException("Efficiency of the converter of PvInput must be between 0% and 100%", invalidPV)
     SystemParticipantTestData.pvInput.copy().elevationAngle(Quantities.getQuantity(100d, SOLAR_ELEVATION_ANGLE)).build() || 1            || new InvalidEntityException("Tilted inclination from horizontal of PvInput must be between 0° and 90°", invalidPV)
     SystemParticipantTestData.pvInput.copy().cosPhiRated(2).build()                                                      || 1            || new InvalidEntityException("Rated power factor of PvInput must be between 0 and 1", invalidPV)

From ce011c37697f78797a9bb461427a56d6c591aed6 Mon Sep 17 00:00:00 2001
From: pierrepetersmeier <155652256+pierrepetersmeier@users.noreply.github.com>
Date: Fri, 23 May 2025 13:32:47 +0200
Subject: [PATCH 2/5] Fix failed test

---
 .../validation/SystemParticipantValidationUtilsTest.groovy      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy b/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
index add28c7b1..6a23a88d1 100644
--- a/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
+++ b/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
@@ -365,7 +365,7 @@ class SystemParticipantValidationUtilsTest extends Specification {
     invalidPV                                                                                                            || expectedSize || expectedException
     SystemParticipantTestData.pvInput.copy().sRated(Quantities.getQuantity(-25d, ACTIVE_POWER_IN)).build()               || 1            || new InvalidEntityException("The following quantities have to be zero or positive: -25 kVA", invalidPV)
     SystemParticipantTestData.pvInput.copy().albedo(2).build()                                                           || 1            || new InvalidEntityException("Albedo of the plant's surrounding of PvInput must be between 0 and 1", invalidPV)
-    SystemParticipantTestData.pvInput.copy().azimuth(Quantities.getQuantity(-181d, AZIMUTH)).build()                     || 1            || new InvalidEntityException("Azimuth angle of PvInput must be between -90° (east) and 90° (west)", invalidPV)
+    SystemParticipantTestData.pvInput.copy().azimuth(Quantities.getQuantity(-181d, AZIMUTH)).build()                     || 1            || new InvalidEntityException("Azimuth angle of PvInput  must be between  0° (south), 90° (west), -90° (east), +/- 180° (north)", invalidPV)
     SystemParticipantTestData.pvInput.copy().etaConv(Quantities.getQuantity(110d, EFFICIENCY)).build()                   || 1            || new InvalidEntityException("Efficiency of the converter of PvInput must be between 0% and 100%", invalidPV)
     SystemParticipantTestData.pvInput.copy().elevationAngle(Quantities.getQuantity(100d, SOLAR_ELEVATION_ANGLE)).build() || 1            || new InvalidEntityException("Tilted inclination from horizontal of PvInput must be between 0° and 90°", invalidPV)
     SystemParticipantTestData.pvInput.copy().cosPhiRated(2).build()                                                      || 1            || new InvalidEntityException("Rated power factor of PvInput must be between 0 and 1", invalidPV)

From 317376aae8286284423aca506b7e999bdff09ab0 Mon Sep 17 00:00:00 2001
From: Pierre <155652256+pierrepetersmeier@users.noreply.github.com>
Date: Mon, 26 May 2025 10:37:38 +0200
Subject: [PATCH 3/5] Update SystemParticipantValidationUtils.java

---
 .../utils/validation/SystemParticipantValidationUtils.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java b/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
index 35930dc11..42e73d552 100644
--- a/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
+++ b/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
@@ -441,7 +441,7 @@ private static void checkAzimuth(PvInput pvInput) throws InvalidEntityException
       throw new InvalidEntityException(
           "Azimuth angle of "
               + pvInput.getClass().getSimpleName()
-              + " must be between  0° (south), 90° (west), -90° (east), +/- 180° (north)",
+              + " must be between 0° (south), 90° (west), -90° (east), +/- 180° (north)",
           pvInput);
   }
 

From 762c1203ac6da42443f81606a013d14ca7990d00 Mon Sep 17 00:00:00 2001
From: pierrepetersmeier <155652256+pierrepetersmeier@users.noreply.github.com>
Date: Wed, 28 May 2025 15:24:09 +0200
Subject: [PATCH 4/5] Fix correct expected exception message in PV validation
 test

---
 .../validation/SystemParticipantValidationUtilsTest.groovy      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy b/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
index 6a23a88d1..125eec5c7 100644
--- a/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
+++ b/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
@@ -365,7 +365,7 @@ class SystemParticipantValidationUtilsTest extends Specification {
     invalidPV                                                                                                            || expectedSize || expectedException
     SystemParticipantTestData.pvInput.copy().sRated(Quantities.getQuantity(-25d, ACTIVE_POWER_IN)).build()               || 1            || new InvalidEntityException("The following quantities have to be zero or positive: -25 kVA", invalidPV)
     SystemParticipantTestData.pvInput.copy().albedo(2).build()                                                           || 1            || new InvalidEntityException("Albedo of the plant's surrounding of PvInput must be between 0 and 1", invalidPV)
-    SystemParticipantTestData.pvInput.copy().azimuth(Quantities.getQuantity(-181d, AZIMUTH)).build()                     || 1            || new InvalidEntityException("Azimuth angle of PvInput  must be between  0° (south), 90° (west), -90° (east), +/- 180° (north)", invalidPV)
+    SystemParticipantTestData.pvInput.copy().azimuth(Quantities.getQuantity(-181d, AZIMUTH)).build()                     || 1            || new InvalidEntityException("Azimuth angle of PvInput must be between 0° (south), 90° (west), -90° (east), +/- 180° (north)", invalidPV)
     SystemParticipantTestData.pvInput.copy().etaConv(Quantities.getQuantity(110d, EFFICIENCY)).build()                   || 1            || new InvalidEntityException("Efficiency of the converter of PvInput must be between 0% and 100%", invalidPV)
     SystemParticipantTestData.pvInput.copy().elevationAngle(Quantities.getQuantity(100d, SOLAR_ELEVATION_ANGLE)).build() || 1            || new InvalidEntityException("Tilted inclination from horizontal of PvInput must be between 0° and 90°", invalidPV)
     SystemParticipantTestData.pvInput.copy().cosPhiRated(2).build()                                                      || 1            || new InvalidEntityException("Rated power factor of PvInput must be between 0 and 1", invalidPV)

From abd6dca9a078cc2bdf4aa33eb4c2f93063955888 Mon Sep 17 00:00:00 2001
From: pierrepetersmeier <155652256+pierrepetersmeier@users.noreply.github.com>
Date: Thu, 29 May 2025 22:01:19 +0200
Subject: [PATCH 5/5] Correct azimuth error message

---
 .../utils/validation/SystemParticipantValidationUtils.java      | 2 +-
 .../validation/SystemParticipantValidationUtilsTest.groovy      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java b/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
index 42e73d552..c68db81f1 100644
--- a/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
+++ b/src/main/java/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtils.java
@@ -441,7 +441,7 @@ private static void checkAzimuth(PvInput pvInput) throws InvalidEntityException
       throw new InvalidEntityException(
           "Azimuth angle of "
               + pvInput.getClass().getSimpleName()
-              + " must be between 0° (south), 90° (west), -90° (east), +/- 180° (north)",
+              + " must be between -180° and 180°",
           pvInput);
   }
 
diff --git a/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy b/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
index 125eec5c7..0992c426b 100644
--- a/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
+++ b/src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy
@@ -365,7 +365,7 @@ class SystemParticipantValidationUtilsTest extends Specification {
     invalidPV                                                                                                            || expectedSize || expectedException
     SystemParticipantTestData.pvInput.copy().sRated(Quantities.getQuantity(-25d, ACTIVE_POWER_IN)).build()               || 1            || new InvalidEntityException("The following quantities have to be zero or positive: -25 kVA", invalidPV)
     SystemParticipantTestData.pvInput.copy().albedo(2).build()                                                           || 1            || new InvalidEntityException("Albedo of the plant's surrounding of PvInput must be between 0 and 1", invalidPV)
-    SystemParticipantTestData.pvInput.copy().azimuth(Quantities.getQuantity(-181d, AZIMUTH)).build()                     || 1            || new InvalidEntityException("Azimuth angle of PvInput must be between 0° (south), 90° (west), -90° (east), +/- 180° (north)", invalidPV)
+    SystemParticipantTestData.pvInput.copy().azimuth(Quantities.getQuantity(-181d, AZIMUTH)).build()                     || 1            || new InvalidEntityException("Azimuth angle of PvInput must be between -180° and 180°", invalidPV)
     SystemParticipantTestData.pvInput.copy().etaConv(Quantities.getQuantity(110d, EFFICIENCY)).build()                   || 1            || new InvalidEntityException("Efficiency of the converter of PvInput must be between 0% and 100%", invalidPV)
     SystemParticipantTestData.pvInput.copy().elevationAngle(Quantities.getQuantity(100d, SOLAR_ELEVATION_ANGLE)).build() || 1            || new InvalidEntityException("Tilted inclination from horizontal of PvInput must be between 0° and 90°", invalidPV)
     SystemParticipantTestData.pvInput.copy().cosPhiRated(2).build()                                                      || 1            || new InvalidEntityException("Rated power factor of PvInput must be between 0 and 1", invalidPV)